Exposed sort filters don't have the correct default values [#2037211]

Exposed sort filters don't have the correct default values when they are used as a setting of a view pane.
I have the following scenario:
I have a view pane. I exposed a number of filter and sorting criteria as e settings of the pane. Whit the filter criteria I have no issues but the sorting settings are not prefilled with the previously selected option into the pane form.

I checked the views_plugin_exposed_form class which creates the form elements for the sort filtering and noticed that it does not populate the default values at all based on the input values. It always takes the default value and that's it.

Comment	File	Size	Author
#5	views-exposed_sort_filters-2037211-5.patch	1.36 KB	Andrew Answer
#5	7.x-3.x: PHP 7.1 & MySQL 5.5, D7 232 pass
#2	exposed_sort_filters-2037211-2.patch	1.4 KB	boyan.borisov
#2
#1	exposed_sort_filters-2037211-1.patch	2.11 KB	boyan.borisov
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

boyan.borisov CreditAttribution: boyan.borisov commented 8 July 2013 at 15:22

Status:

Active

» Needs review

File	Size
exposed_sort_filters-2037211-1.patch	2.11 KB

I modified the views_plugin_exposed_form class to populated the default values based on $this->view->exposed_input

Comment #2

boyan.borisov CreditAttribution: boyan.borisov commented 8 July 2013 at 20:50

File	Size
exposed_sort_filters-2037211-2.patch	1.4 KB

Please, ignore the patch from comment #1. It overrides some other changes on dev which I missed.

I am providing the correct patch.

Comment #3

boyan.borisov CreditAttribution: boyan.borisov commented 23 July 2013 at 15:15

Any comments?

Comment #4

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 7 January 2019 at 21:23

Issue summary:	View changes
Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

2 files were hidden/shown/deleted

File	Size
exposed_sort_filters-2037211-1.patch	2.11 KB

exposed_sort_filters-2037211-2.patch	1.4 KB

The 6 year old patch in #2 to views_plugin_exposed_form.inc does not apply to the latest views 7.x-3.x-dev and if still applicable needs reroll.

Checking patch plugins/views_plugin_exposed_form.inc...
error: while searching for:
    }

    if (count($exposed_sorts)) {
      $form['sort_by'] = array(
        '#type' => 'select',
        '#options' => $exposed_sorts,
        '#title' => $this->options['exposed_sorts_label'],
      );
      $sort_order = array(
        'ASC' => $this->options['sort_asc_label'],
        'DESC' => $this->options['sort_desc_label'],
      );
      if (isset($form_state['input']['sort_by']) && isset($this->view->sort[$form_state['input']['sort_by']])) {
        $default_sort_order = $this->view->sort[$form_state['input']['sort_by']]->options['order'];
      } else {
        $first_sort = reset($this->view->sort);

error: patch failed: plugins/views_plugin_exposed_form.inc:220
error: plugins/views_plugin_exposed_form.inc: patch does not apply