Using the apacheolr_views_query plugin causes the following notices to show when grouping_info is an empty array.

    Notice: Undefined index: group in apachesolr_views_query->build() (line 123 of /apachesolr_views_query.inc).
    Notice: Undefined index: group in apachesolr_views_query->execute() (line 186 of /apachesolr_views/apachesolr_views_query.inc).

The attached patch introduces an isset test to avoid this.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daniel.rolls@flightcentre.com.au’s picture

Status: Active » Needs review

Changed status to needs review.

DeFr’s picture

Version: 7.x-1.0-beta2 » 7.x-1.x-dev
Status: Needs review » Needs work

Running the latest beta, I have a notice related to grouping too. (Notice : Undefined property: apachesolr_views_query::$group_operator dans apachesolr_views_query->build() (line 80 of sites/all/modules/contrib/apachesolr_views/apachesolr_views_query.inc).

Not sure against which version the patch was made, but it doesn't apply and the patch context doesn't match anything that's actually in http://drupalcode.org/project/apachesolr_views.git/blob/c2b0ab5b9e290aa7... . Do you have other patches already applied ?

DeFr’s picture

Issue summary: View changes

Fixing my grammar.

MiroslavBanov’s picture

Issue summary: View changes
Status: Needs work » Fixed

Problem in issue summary is non-reproducible, and the patch doesn't apply - the lines that are supposed to be fixed don't exist in current dev, or beta3.

The problems in comments #2, #2.0 duplicate and are fixed in #1761432: Undefined property: apachesolr_views_query::$group_operator line 83 apachesolr_views_query.inc.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.