As users looking at styleguide may not be technical (I use it to help editors know what each style means) it would be useful to show what image style effects are in use, and what size the image is.

CommentFileSizeAuthor
#3 styleguide-2035567-3.patch1.21 KBtim.plunkett
#1 styleguide-show_image_effects-2035567-1.patch1.23 KBmalcomio
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

malcomio’s picture

malcomio CreditAttribution: malcomio commented
Status: Active » Needs review
FileSize
styleguide-show_image_effects-2035567-1.patch1.23 KB
dead_arm’s picture

dead_arm
she/her
Primary language English
CreditAttribution: dead_arm commented
Issue summary: View changes
Status: Needs review » Needs work

Thanks for the patch!

  1. +++ b/modules/image.inc
@@ -18,9 +18,28 @@ function image_styleguide() {
+        $effect_details .= t(', upscaling allowed');
...
+        $effect_details .= t(' Height ') . $effect['data']['height'];
...
+        $effect_details .= t(' Width ') . $effect['data']['width'];

    It's not good for translators to include spaces and punctuation like this. 

  2. +++ b/modules/image.inc
@@ -18,9 +18,28 @@ function image_styleguide() {
+      $effect_details = '<em>' . $effect['label'] . '</em>';

    There are API functions to add em tags, and the label should be sanitized.

Additionally, this only covers one or two effects. It won't work for things like 'desaturate' or 'rotate', or any contrib effects.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
styleguide-2035567-3.patch1.21 KB

Image effects provide a summary functionality that can be used here.

dead_arm’s picture

dead_arm
she/her
Primary language English
CreditAttribution: dead_arm commented
Status: Needs review » Reviewed & tested by the community

Works for me.

dead_arm’s picture

dead_arm
she/her
Primary language English
CreditAttribution: dead_arm commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed!

  • Commit c108adf on 7.x-1.x authored by malcomio, committed by dead_arm: 
    Issue #2035567 by tim.plunkett, malcomio: Image styles should tell the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.