Option to display media player instead of link

Thanks for the patch. Just to clarify, I no longer work for Nomensa, so I wouldn't feel right making any further changes to the module without their prior approval. I've sent an email so hopefully I or someone else will be committing your patch soon.

In the meantime, I will review the patch on my own site and report back.

Yes, thanks for a great module, especially for non-tech people like me. What do you think if we can have a feature as a block to show the player and file links are still kept as they are. I am helping a library site for the blind users and they prefer to download the files instead of streaming online. However, they would like to have a player to help them hear a bit of the file before downloading. I am using screen reader and cannot find the link to download when enable the module.
For the moment, if you have any ideas on how to customize the code to add this option, please help. Thanks

@danghoaiphuc, it all depends in what way you're using the player. If you're using it to stream YouTube videos, then you won't be able to download them. Please create a new issue for this, using the feature request category.

Thanks.

Thanks @opdavies and @rli. Will post a new feature request. Our file host is on 4shared.com and wee have the direct links to download files from there. So we just copy those direct download links from 4shared and paste into our website. If so, does it work with your patch, @rli? Thanks.

Works beautifully for D7.

Is there a D6 version of the patch?

@rli: I've committed the patch to 7.x-1.x, and fixed an "undefined index" notice that was appearing if the admin form hadn't been submitted so the class name wasn't defined.

However, if I add a class of "player3" rather than just "player", the player still loads. Setting it to something else like "foo" (that doesn't have "player" in it) prevents the player from loading.

Committed. Thanks!

@rli: Would it be possible to change this around, and add a class of .no-player instead to prevent the player from loading rather than the other way around? The inverse way means that sites currently using the module won't all suddenly stop working, and we're not deviating away from the standard functionality of the player.

+++ b/nomensa_amp.module
@@ -130,3 +136,11 @@ function nomensa_amp_requirements($phase) {
+
+/**
+ * Implement hook_js_alter()
+ */
+function nomensa_amp_js_alter(&$javascript) {
+  $file = drupal_get_path('module', 'nomensa_amp') . '/nomensa_amp.jquery.loader.js';
+  $javascript['sites/all/libraries/nomensa_amp/custom/javascript/jquery.loader.js'] = drupal_js_defaults($file);
+}

It looks like this is replacing the JS file from the NomensaAMP library with a copy that is now in this module.

I assume the reason for this is that the module's copy differs from the NomensaAMP library version.

This approach strikes me as a very bad idea.

It looks like this is replacing the JS file from the NomensaAMP library with a copy that is now in this module.

I assume the reason for this is that the module's copy differs from the NomensaAMP library version.

This approach strikes me as a very bad idea.

Thanks for pointing this out, and I agree completely. Two commits for this were causing #2389975: Javascript breaks across site in latest version, so are no longer present in the 7.x-1.4 release.

Any changes to the player functionality should be made upstream by forking the media player repository on GitHub and submitting a pull request, so I'm marking this issue as "works as designed". An issue can then be created here to update the version of the player to use when needed.