Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
bxSliderInitialize calls jQuery(slideShow).bxSlider with a wrong encoded object which ends with comma, which produces an error in Internet Explorer
Comments
Comment #1
grisendo CreditAttribution: grisendo commentedI attach a patch
Comment #2
Mschudders CreditAttribution: Mschudders commentedOdd that I do not have this on my website ie: http://mschudders.equality-sports.com/bx-slider-carrousel
tested in IE 7 + 8 + 9
Comment #3
mhkc CreditAttribution: mhkc commentedNot working for me in IE 10. Just ... doesn't slide.
Comment #4
Mschudders CreditAttribution: Mschudders commentedTested it on W7 with IE10 @ http://mschudders.equality-sports.com/bx-slider-carrousel
No problems. Could you attach a screenshot ?
Thanks
Comment #5
grisendo CreditAttribution: grisendo commentedI attach two screenshots (sorry, spanish browser!)
In IE<10, the comma at the end of the last object item generates an error, so slider is not applied at all. The two screenshots are from that case.
In IE10 (windows 8), the comma at the end doesn't generate an error, and the slider is "applied", but slides don't advance automatically, and next/prev buttons doesn't work when clicking them. Here, I can't show this case with screenshots :(
Comment #6
Mschudders CreditAttribution: Mschudders commentedSo you have the problem in IE 7 ? (Taken from your screenshots. )
As a last test do these examples here work for you : http://bxslider.com/examples and here http://mschudders.equality-sports.com/bx-slider-carrousel ?
Thanks
Comment #7
grisendo CreditAttribution: grisendo commentedBoth example pages work for me in IE7, IE8, IE9 and IE10. The first page is the official's, and this module is not used. In the second, maybe you are using any old version?
With a fresh latest BxSlider - Views slideshow integration downloaded in a fresh latests drupal 7, it generate those errors in any version of IE from 7 to 10, because of that final comma.
Comment #8
Mschudders CreditAttribution: Mschudders commentedThanks I will have a look at it.
Will update to the latest BxSlider lib.
Comment #9
Mschudders CreditAttribution: Mschudders commentedComment #10
Mschudders CreditAttribution: Mschudders commentedUpdated to the latest versions but cannot reproduce. Will try to test on an W8 pc if I can get my hands on it :-)
Comment #11
Mschudders CreditAttribution: Mschudders commentedDo you have a link where I can check your site ?
Thanks.
Comment #12
grisendo CreditAttribution: grisendo commentedI set my site temporally to "Production", it was in "Maintenance mode". Is a dirty sandbox, don't get panic :P
Url with the View is: http://www.grisendo.com/testbx
Comment #13
Mschudders CreditAttribution: Mschudders commentedWeird, I can confirm your issue on IE10 & IE 7-
still cannot reproduce on mine.
But will apply your patch !
tHanks
Comment #14
Mschudders CreditAttribution: Mschudders commentedpushed to the latest dev release. Could you confirm that the latest dev release is working for you ?
Thanks.
Comment #15
grisendo CreditAttribution: grisendo commentedPatch is applied only partially. There are some lines you didn't applied, and if I configure an "onSlideNext" function (and no "onSlidePrev" function), the object still finishes with comma and breaks IE.
You can check this in the same url: http://www.grisendo.com/testbx
Comment #16
grisendo CreditAttribution: grisendo commentedIn fact, my original patch is wrong also: if I set a "callback" option (i.e. onSlideNext), no comma is generated between "autoDirection" and "onSlideNext" :(
This patch I attach now (generated from the latest DEV version from today, not from 2013-07-03 version) is the right one, I made some tests and I think is OK now... please, test after patching.
(PS: Commit authoring is not required, but I'll be very happy if you do it :D)
Comment #17
Mschudders CreditAttribution: Mschudders commentedIll use it in my deploy (normally this weekend I hope!)
--author="grisendo "
Comment #18
Mschudders CreditAttribution: Mschudders commentedAdded to latest dev.
Todo test this :-).
Comment #19
grisendo CreditAttribution: grisendo commentedThank you for the authoring, you made my day! :D
Comment #20
Mschudders CreditAttribution: Mschudders commentedGlad I could help !
Can you confirm this fix is working for you ?
Comment #21
grisendo CreditAttribution: grisendo commentedI don't have access to a Windows, I'll test as soon as I can.