PHPDoc in WebTestBase::setUp() states that it would take a parameter, but it doesn't. Seems to be a leftover.

Also, the $modules property should be defined and documented in WebTestBase.
The fact that it isn't, might be to allow for collecting the $modules from inheriting classes with this code:

    while ($class) {
      if (property_exists($class, 'modules')) {
        $modules = array_merge($modules, $class::$modules);
      }
      $class = get_parent_class($class);
    }

but maybe we can solve that differently.
It would really be nice to replace all the same generic PHPDocs by @inheritdoc in the test classes.

Comments

Pancho’s picture

Issue summary: View changes

Updated issue summary.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

You can see the current docblock for WebTestBase::setUp() here: https://api.drupal.org/api/drupal/core%21modules%21simpletest%21src%21We...

It doesn't seem to mention passing in parameters.

It does say how to set up ::modules and ::profile, and of course the full documentation is on FunctionalTestSetupTrait::installModulesFromClassProperty here: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Test%21Fu...

If there are any specific improvements, maybe give more specific details and/or a patch. Thanks.

Mile23’s picture

Status: Postponed (maintainer needs more info) » Closed (duplicate)