Diff assumes that the HTML ID of a node is node-NID, which is how it addresses the node as an AJAX wrapper for handling "inline diff" functionality.

But the Omega theme does this:

function omega_alpha_preprocess_node(&$vars) {
  // Prepare the arrays to handle the classes and ids for the node container.
  $vars['attributes_array']['id'] = drupal_html_id('node-' . $vars['type'] . '-' . $vars['nid']);
  // ....
}

If the node type is removed from the HTML ID (is there a reason why Omega includes the node type?), then inline diffs will work again.

(This is related to the Diff issue #1310422: Inline diff not rendered. The fix in that issue won't work for sites using Omega)

Files: 
CommentFileSizeAuthor
#2 omega-2033239-2.patch598 bytespjcdawkins
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
#1 omega-2033239.patch560 bytespjcdawkins
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Comments

pjcdawkins’s picture

Status: Active » Needs review
FileSize
560 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
pjcdawkins’s picture

FileSize
598 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Actually it looks like the theme layer does need to set the node ID, but it shouldn't be including the node type.

pjcdawkins’s picture

Issue summary: View changes

Updated issue summary.