SearchSettingsForm implements CMI incorrectly.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -1,13 +1,14 @@
- * Contains \Drupal\search\Form\SearchSettingsForm.
+ * Contains \Drupal\search\Form\configFactoryForm.

Still an accidental rename here.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -39,17 +33,17 @@ class SearchSettingsForm extends SystemConfigFormBase {
     $this->moduleHandler = $module_handler;
     $this->state = $state;
+    parent::__construct($config_factory, $context);

the parent call usually happens first.

This is just a bugfix, no API change :)

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -39,17 +33,18 @@ class SearchSettingsForm extends SystemConfigFormBase {
-   * Constructs a \Drupal\user\SearchSettingsForm object.
+   * Constructs a \Drupal\user\configFactoryForm object.

Another invalid rename here :)

The namespace is actually wrong here, let's change \user\ to \search\Form\ while we're here.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -39,17 +33,18 @@ class SearchSettingsForm extends SystemConfigFormBase {
    * @param \Drupal\Core\Config\Config $search_settings
    *   The configuration object that manages search settings.
    * @param \Drupal\Core\Extension\ModuleHandler $module_handler
    *   The module handler

The @param's need to be reflected for the changed arguments.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -39,17 +33,18 @@ class SearchSettingsForm extends SystemConfigFormBase {
     $this->state = $state;
+    ¶

Now there's an empty line with trailing spaces here, that should be removed.

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -39,17 +33,21 @@ class SearchSettingsForm extends SystemConfigFormBase {
+   *   The Key Value Store Interface, gives access to state based config settings.

"The state key/value store."

+++ b/core/modules/search/lib/Drupal/search/Form/SearchSettingsForm.phpundefined
@@ -39,17 +33,21 @@ class SearchSettingsForm extends SystemConfigFormBase {
-    $this->state = $state;
+    $this->state = $state;  ¶

Trailing spaces.

+ * Constructs a \Drupal\search\Form\SystemConfigFormBase object.

This is a \Drupal\search\Form\SearchSettingsForm object.

Looks RTBC to me presuming the tests pass.

#22: drupal-2032235-22.patch queued for re-testing.

Seemingly unrelated failure in CommentLinksTest, let's see if this one runs green.

Committed be35585 and pushed to 8.x. Thanks!