Implement checkCreateAccess on LanguageAccessController [#2031277]

Follow-up for #1754246: Languages should be configuration entities

Problem/Motivation

Languages now configuration objects so their routers used own accessChecks

Proposed resolution

Implement all needed methods of LanguageAccessController for Language configurable entity and use it for all access checks on routes

#1946426: Convert all of confirm_form() in language.admin.inc to the new form interface
#2003592: Convert language_admin_add_form and language_admin_edit_form to a Controllers
#2005778: Convert language_admin_overview_form to a Controller

Comment	File	Size	Author
#11	2031277-11.patch	680 bytes	andypost
#11
#1	2031277-language-access-controller-1.patch	1.92 KB	vijaycs85
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

File	Size
2031277-language-access-controller-1.patch	1.92 KB

Comment #2

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 4 July 2013 at 11:06

may need to close as this part covered in #2005778: Convert language_admin_overview_form to a Controller ?

Comment #3

andypost

he/him

Russian

CreditAttribution: andypost commented 4 July 2013 at 12:42

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

We need list operation implementation so suppose better to make whole feature in #2005778: Convert language_admin_overview_form to a Controller
Let's use the issue to test patches to implement access controller with unittest

NW for

+++ b/core/modules/language/lib/Drupal/language/Controller/LanguageAccessController.phpundefined
@@ -0,0 +1,36 @@
+        $language = language_load($entity->id);
+        return !$language->locked && user_access('administer languages');

return !$entity->locked && user_access('adminster languages')

Comment #4

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 4 July 2013 at 12:53

Issue tags:

-Needs tests

:D @andypost that's what happen when blindly convert ;) Thanks for the review. I have updated the overview page issue with your review comment in #3

Comment #5

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 4 July 2013 at 12:54

Issue tags:

+Needs tests

Comment #6

YesCT CreditAttribution: YesCT commented 4 July 2013 at 13:06

+++ b/core/modules/language/lib/Drupal/language/Controller/LanguageAccessController.phpundefined
@@ -0,0 +1,36 @@
+        return !$language->locked && user_access('administer languages');

Can we add an @see to the class (or something) where we define what locked is?

I remember it's the undefined and not applicable, but would be good to have a reference here, so we know why we do not allow editing or deleting those system (hidden) languages.

Comment #7

webflo CreditAttribution: webflo commented 4 July 2013 at 14:23

+++ b/core/modules/language/lib/Drupal/language/Controller/LanguageAccessController.phpundefined
@@ -0,0 +1,36 @@
+        return user_access('administer languages');
...
+        return !$language->locked && user_access('administer languages');

Pass $account to the user_access().

Comment #8

YesCT CreditAttribution: YesCT commented 4 July 2013 at 16:50

Actually, someone could just look up that property, so we might not want an @see

...
When I looked up the property, I found no docs. :)
So:
#2035007: Add docs for properties in Drupal\Core\Language\Language

Comment #9

penyaskito

he/him

Spanish

🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺

CreditAttribution: penyaskito commented 12 July 2013 at 18:15

Status:

Needs work

» Needs review

#2005778: Convert language_admin_overview_form to a Controller landed, and includes a LanguageAccessController. Should we close this one? Are there any more tests needed?

Comment #10

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 14 August 2013 at 16:54

Status:

Needs review

» Closed (duplicate)

Looks like already resolved to me(?)

Comment #11

andypost

he/him

Russian

CreditAttribution: andypost commented 15 August 2013 at 01:07

Title:	Introduce an LanguageAccessController for Language entities	» Implement checkCreateAccess on LanguageAccessController
Status:	Closed (duplicate)	» Needs review
Issue tags:	-Needs tests