[D7] Scald Commerce Product

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

You need a description to your project page. As written in the review list that is pointed out by PA robot. Also what is Scald anyway.

• scald_commerce_product.install
• line 8 : this is not a standard comment. Should be removed.
• scald_commerce_product.module
• line 8 : this is not a standard comment. Should be removed.
• line 13 : sook_scald_providers() should be hook_scald_atom_providers().
• line 26 : add a blank line between Implements hook_scald_add_form() and your description.
• line 53 : comment line should not exceed 80 columns.
• line 54 : why not using the wrapped entity here ? eg.
  

  $product_image = $wrapper_product->{$field_name_product_image}->value();
  if (!empty($product_image)) {
    $atom->scald_thumbnail[LANGUAGE_NONE][0] = $product_image;
    break;
  }
  

• line 76 : missing parameter type. I guess @param string $id
• line 91 : you are supposed to get the element value from $element['#value']

Would be nice to have more description in the README.txt.

Hi,

Your README.txt should contain the same description as the one on your project page.
Otherwise, I think it's an interesting module..

Hi,

after some testing and research in the code :
- add dependencies on commerce_product
- how will work the display part, using a buildmode ?
- I agree with your nextstep, it would be nice to have an autocomplete field on the sku for the creation of an atom

anyway it's a good project.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/README.txt
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
  --------------------------------------------------------------------------------
    8 | WARNING | Line exceeds 80 characters; contains 114 characters
   14 | WARNING | Line exceeds 80 characters; contains 109 characters
  --------------------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/scald_commerce_product.module
  --------------------------------------------------------------------------------
  FOUND 3 ERROR(S) AND 2 WARNING(S) AFFECTING 5 LINE(S)
  --------------------------------------------------------------------------------
   21 | WARNING | Code after RETURN statement cannot be executed
   46 | ERROR   | Expected "if (...) {\n"; found "if (...){\n"
   55 | WARNING | There must be no blank line following an inline comment
   56 | ERROR   | Whitespace found at end of line
   80 | ERROR   | Missing parameter type at position 1
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• scald_commerce_product.info: why is the CSS added on every single page request? I think it is only needed for admins that use the scald menu?

But that are not blockers, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to kscheirer as he might have time to take a final look at this.

You have a typo in scald_commerce_product_install(), Ressource should be Resource.

I'm not sure I understand this - what is the module 'mee' ?

  function scald_commerce_product_library_alter(&$libraries, $module) {
    if ($module == 'mee') {
      $libraries['library']['css'][] = drupal_get_path('module', 'scald_commerce_product') . '/scald_commerce_product.css';
    }
  }

However those are minor issues, so...

Thanks for your contribution, asplamagnifique!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Enterprise modules from the community for the community.