Convert BLOCK_LABEL_VISIBLE to a constant on the block interface [#2029677]

Comment	File	Size	Author
#6	convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-6.patch	4.05 KB	afeijo

#5	convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-5.patch	4.05 KB	afeijo

#3	convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-3.patch	4.05 KB	afeijo

#1	Convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-2.patch	3.42 KB	afeijo

Comment #1

Portuguese, Brazil

Porto Alegre

CreditAttribution: afeijo commented 29 June 2013 at 03:22

Assigned:	Unassigned	» afeijo
Status:	Active	» Needs review

File	Size
Convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-2.patch	3.42 KB

Like that?

Log in or register to post comments

Comment #2

29 June 2013 at 04:04

Status:

Needs review

» Needs work

The last submitted patch, Convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-2.patch, failed testing.

Log in or register to post comments

Comment #3

afeijo

Portuguese, Brazil

Porto Alegre

CreditAttribution: afeijo commented 30 June 2013 at 06:16

Status:

Needs work

» Needs review

File	Size
convert-BLOCK_LABEL_VISIBLE-to-a-constant--2029677-3.patch	4.05 KB

New try, this time I ran simpletest locally and it worked

my original patch was missing the use line where the block simpletest files needs our constant

Log in or register to post comments

Comment #4

dawehner

German

CreditAttribution: dawehner commented 30 June 2013 at 16:15

These are the only 5 places for this constant.

+++ b/core/modules/block/lib/Drupal/block/BlockInterface.phpundefined
@@ -13,6 +13,10 @@
 interface BlockInterface extends ConfigEntityInterface {
+  /**

The documentation standard says, that there should be an empty line between the { and the first actual documentation.