#111715: Convert node/content types into configuration landed. #2029405: Write configuration schema for node types is open to write schemas. Once schemas are there, we would only need to wire them in to config translation I think. Even before that, we could add the list controller support, even if it would not work due to missing schema.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

Status: Active » Needs review
FileSize
590 bytes

Initial patch...

vijaycs85’s picture

Issue tags: -D8MI, -language-config

#1: 2029407-node-type-1.patch queued for re-testing.

vijaycs85’s picture

#1: 2029407-node-type-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D8MI, +language-config

The last submitted patch, 2029407-node-type-1.patch, failed testing.

Gábor Hojtsy’s picture

Should also expand listing tests in the module :)

shnark’s picture

Status: Needs work » Needs review
FileSize
556 bytes

Reroll. The context lines were messed up, but the bottom one was still there so I could line it up.
next I'm going to try to expand the listing tests like mentioned in comment #5, I've never done tests before, so I don't know if I'll get through it.

shnark’s picture

I wrote the test, using the format from the other tests in that same file.
I also moved something from the other patch so it was in alphabetical order.

shnark’s picture

FileSize
2.76 KB

Sorry, I didn't diff against the right thing.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

Yay, looks amazing! Committed this! Also added you to the commit message line in #1952394: Add configuration translation user interface module in core. Thanks for working on this!

Automatically closed -- issue fixed for 2 weeks with no activity.