Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Hey,
how about replacing the current Shadow with a CSS3-Shadow?
That would make many div's needless.
I will create a patch for this.
Regards, lucastockmann
Comment | File | Size | Author |
---|---|---|---|
#6 | outsourcing_of_the_conditional_comments-2028627-6.patch | 5.39 KB | lucastockmann |
#4 | IE7,IE8.jpg | 327.99 KB | lucastockmann |
#4 | IE9.jpg | 135.51 KB | lucastockmann |
#4 | IE10.jpg | 141.62 KB | lucastockmann |
#4 | new_css3_shadow_and_some_fixes-2028627-4.patch | 14.93 KB | lucastockmann |
Comments
Comment #1
lucastockmann CreditAttribution: lucastockmann commentedI've replaced the old shadow with a new CSS3-Shadow.
It looks fine for me.
Comment #2
aschiwi CreditAttribution: aschiwi commentedVery cool! It looks perfect in Chrome. The shadow looks a little too far out in Firefox and Safari, can you fix that? And do you have a screenshot of what it looks like in Internet Explorer (7 to current)?
Comment #3
lucastockmann CreditAttribution: lucastockmann commentedThe Problem is that Firefox, Safari and Chrome all interpret the CSS different. Therefore it isn't possible to make it look in all Browsers the same. I attached a file that compares each browser to the original version of busy to get a overview about the differences.
And the Internet Explorer 8 and lower can't CSS3 what it makes more complicated. I would prefer to load the wrapper's for the shadow conditional, because there is no workaround to get a box-shadow with gradients.
Comment #4
lucastockmann CreditAttribution: lucastockmann commentedWith the Patch the following things get done:
I attached some screenshots of the shadow in different browser. There are still some differences because the browser interpret the style different. But I hope it looks good.
Comment #5
aschiwi CreditAttribution: aschiwi commentedNice work! Committed to 8.x-1.x.
I would prefer to see the conditional comment div stuff in busy.theme, so they never get to the browser unless using IE.
Comment #6
lucastockmann CreditAttribution: lucastockmann commentedI've outsourced the div's into the busy.theme and tested with IE7 - 9, chrome, safari and firefox.
Nothing unexpected did happen.
Comment #7
aschiwi CreditAttribution: aschiwi commentedThank you - committed to 8.x-1.x.