Hey,

how about replacing the current Shadow with a CSS3-Shadow?
That would make many div's needless.

I will create a patch for this.

Regards, lucastockmann

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lucastockmann’s picture

I've replaced the old shadow with a new CSS3-Shadow.
It looks fine for me.

Busy Demo Site | The ultimate corporate business theme for Drupal....jpg

aschiwi’s picture

Very cool! It looks perfect in Chrome. The shadow looks a little too far out in Firefox and Safari, can you fix that? And do you have a screenshot of what it looks like in Internet Explorer (7 to current)?

lucastockmann’s picture

FileSize
258.59 KB

The Problem is that Firefox, Safari and Chrome all interpret the CSS different. Therefore it isn't possible to make it look in all Browsers the same. I attached a file that compares each browser to the original version of busy to get a overview about the differences.

And the Internet Explorer 8 and lower can't CSS3 what it makes more complicated. I would prefer to load the wrapper's for the shadow conditional, because there is no workaround to get a box-shadow with gradients.

lucastockmann’s picture

FileSize
14.93 KB
141.62 KB
135.51 KB
327.99 KB

With the Patch the following things get done:

  • CSS3 Shadow
  • IE 8 and lower use the old style, because they don't support CSS3
  • Forgotten or statement in page.html.twig get fixed
  • "No newline at end of file" errors get fixed

I attached some screenshots of the shadow in different browser. There are still some differences because the browser interpret the style different. But I hope it looks good.

aschiwi’s picture

Status: Needs review » Active

Nice work! Committed to 8.x-1.x.
I would prefer to see the conditional comment div stuff in busy.theme, so they never get to the browser unless using IE.

lucastockmann’s picture

Status: Active » Needs review
FileSize
5.39 KB

I've outsourced the div's into the busy.theme and tested with IE7 - 9, chrome, safari and firefox.
Nothing unexpected did happen.

aschiwi’s picture

Issue summary: View changes
Status: Needs review » Fixed

Thank you - committed to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.