Wrong strpos() function usage [#2027625]

Hi,

While testing second branch of Cache Expiration I found small bug in usage of strpos() function. See your code (line 382):

if (strpos($base_root, $url) == 0) {

There are two bugs:

First params should be $url (it's haystack) and the second should be $base_root (it's needle here).
Your should use === instead of ==. If you use == even if strpos() returns FALSE the condition will be passed successfully.

Patch that fixes this attached.

Comment	File	Size	Author
	boost-wrokng-strpos-function-usage.patch	519 bytes	Spleshka

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

berdyshev CreditAttribution: berdyshev commented 26 June 2013 at 18:48

Status:

Needs review

» Needs work

I think it should be

if (strpos($url, $base_root) === FALSE) {

because strpos() function returns FALSE if there is no occurrence found. And you use === which means the comparison by value and type.

Comment #2

Spleshka

he/him

English

UAE

CreditAttribution: Spleshka commented 26 June 2013 at 19:09

Status:

Needs work

» Needs review

Sorry, but you are wrong. We need strpos() to return 0, not FALSE. It means that $base_root was found in $url starting with the first letter. In other cases condition should fail.