When inserting an image using the media plugin you get options to set the alt text and title text, but these attributes never end up on the image.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rooby’s picture

Status: Active » Needs review
FileSize
1.13 KB

This patch fixes it for me.

klokie’s picture

Priority: Normal » Major
Issue summary: View changes

I rerolled the patch from #1 against the latest dev branch. Without this, image tags inserted by media_wysiwyg can be broken by including characters like single quotes in the "title" attribute.

rooby’s picture

Could you post your reroll?

klokie’s picture

Sorry, thought I attached it last time. Here it comes...

rooby’s picture

With latest dev + the patch at #2159403: Make CKEditor plugin system modular and clean this patch applies cleanly but doesn't seem to work.

I will investigate more a bit later.

rooby’s picture

Project: CKEditor 4 - WYSIWYG HTML editor » Media CKEditor
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Needs work

Since #2542566: Remove Media integration the media code is no longer in this module, so moving to media_ckeditor.

The patch will need updating if it is still required.

rooby’s picture

As far as I can tell it is still an issue and the patch doesn't apply or easily reroll.

brockfanning’s picture

Status: Needs work » Closed (duplicate)
Related issues: +#2416701: WYSIWYG Alt and Title overrides do not override

I posted a patch in the Media queue (#2416701-30: WYSIWYG Alt and Title overrides do not override) which, although I haven't gotten any feedback on it, does fix the problem for me. Regardless, since I don't believe this is a Ckeditor-specific problem, we should probably focus efforts on the issue linked above.