Ability to change the port from 35729 to something else would be handy when having livereload-server running on the server with multiple websites, as you can define a port using livereload.

CommentFileSizeAuthor
#4 livereload-ability_to_set_the_port-d8-2026567.patch987 bytesbassie111
#3 livereload-ability_to_set_the_port-2026567-3.patch911 bytesholist
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

minorOffense’s picture

minorOffense CreditAttribution: minorOffense commented

There are similar options in the Load from Drupal section. I could just move them up as shared configuration options. If the maintainer agrees.

Hydra’s picture

Hydra CreditAttribution: Hydra commented

Sure! Show me what you got :) Always open for constructive patches

holist’s picture

holist CreditAttribution: holist commented
Issue summary: View changes
Status: Active » Needs review
FileSize
livereload-ability_to_set_the_port-2026567-3.patch911 bytes

I ran into the multisite issue and decided a slim solution is better than no solution... Here's a quick patch for setting the port from variable that can be configured in settings.php. Like this: $conf['livereload_js_port'] = '35730';.

Sorry, I didn't put effort into making it configurable from the admin UI.

Tried it on 7.x-2.0 (I can post patch for that if someone wants it), does the job.

bassie111’s picture

bassie111 CreditAttribution: bassie111 commented
FileSize
livereload-ability_to_set_the_port-d8-2026567.patch987 bytes

Same for 8.x version.

bassie111’s picture

bassie111 CreditAttribution: bassie111 commented