Problem/Motivation

Currently book module does useless and fragile sorting of allowed types on per-language basis (BookSettingsForm::submitForm() & book_node_type_update())

Proposed resolution

Store and use the array always keyed and implement sorting of localized node type labels only before render for settings and views plugins

API changes

changes a structure of stored settings

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

I don't think we should do this... the reason for the sorting is so that only when you diff CMI files we only see differences that matter.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

See #1933548: Book allowed_types settings repetitive and in under certain conditions can change unexpectedly

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Postponed » Closed (won't fix)

Actually due to #1933548: Book allowed_types settings repetitive and in under certain conditions can change unexpectedly going to won't fix...

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented
Issue summary: View changes
Parent issue: » #111715: Convert node/content types into configuration