Remove ModuleInfo as it is no longer necessary

Fixing component.

Ok, I'm confused.

There are exactly two places left in core that use system_get_module_info(). Did we replace that with the module handler? If we did, then did we introduce a regression?

Patch converts it to cache collector but doesn't make it a service yet.

So... discussed this with @katbailey and @dawehner a bit.

- The main reason this was introduces is *gone* (the stylesheet/js stuff on module .info files)
- There are just two backend places that use it right now, search settings and settings of a specific handler
- There are a few places that could use it, but none seem very relevant to performance: user_admin_permissions(), Permissions::getValueOptions(), Permission::buildOptionsForm(), LayoutController::layoutPageList() (I assume this isn't used now, but could be?), field_help()

So... should we convert it to a service or just kill it, and switch to system_get_info() in these two places (all this stuff should so much be services, oh well...)

Assigning to @catch for feedback, hope that's ok :)

This kills it completely. An alternative would be to keep the helper function but directly access system_get_info() in there?

#5: module-info-2025779-5.patch queued for re-testing.

Doesn't need to be assigned to catch.

+++ b/core/includes/bootstrap.inc
@@ -2594,12 +2594,12 @@ function drupal_classloader_register($name, $path) {
  * Example:
  * @code
- * function system_get_module_info($property) {
- *   static $info;
- *   if (!isset($info)) {
- *     $info = new ModuleInfo('system_info', 'cache');
+ * function drupal_session_started($set = NULL) {
+ *   static $session_started = FALSE;
+ *   if (isset($set)) {
+ *     $session_started = $set;
  *   }
- *   return $info[$property];
+ *   return $session_started && session_id();
  * }
  * @endcode
  *

Hm, did a merge conflict go wrong here? This seems to be adding a new function, which doesn't make sense?

Do we need a short change notice for this?

Created https://drupal.org/node/2188305