Drupal 8 adds the file based configuration system. We should make use of this enhancement.

See: https://drupal.org/node/1500260

CommentFileSizeAuthor
#8 CAPTCHA-2024901-3.patch26.83 KBelachlan
#6 CAPTCHA-2024901-2.patch18.9 KBelachlan
#3 CAPTCHA-2024901-1.patch18.33 KBelachlan
#1 extlink-2029195-1.patch1.67 KBelachlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Active » Needs review
FileSize
extlink-2029195-1.patch1.67 KB

First patch.

Status: Needs review » Needs work

The last submitted patch, extlink-2029195-1.patch, failed testing.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
FileSize
CAPTCHA-2024901-1.patch18.33 KB

Wrong patch!

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, CAPTCHA-2024901-1.patch, failed testing.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs work » Needs review
FileSize
CAPTCHA-2024901-2.patch18.9 KB

Problems with _captcha_get_description() caused by change of langcode to id see: https://drupal.org/node/2031267

Status: Needs review » Needs work

The last submitted patch, CAPTCHA-2024901-2.patch, failed testing.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Needs work » Needs review
FileSize
CAPTCHA-2024901-3.patch26.83 KB

New patch. That should convert it to CMI.

wundo’s picture

wundo CreditAttribution: wundo commented

warning: 5 lines add whitespace errors. ;(

wundo’s picture

wundo CreditAttribution: wundo commented
Status: Needs review » Fixed

I fixed a bunch of whitespace errors and committed your patch.

wundo’s picture

wundo CreditAttribution: wundo commented

(BTW, don't worry I kept you as the commit author)

elachlan’s picture

elachlan CreditAttribution: elachlan commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.