See:
  // These are usually added from system_init() -except maintenance.css.

Needs to be updated or removed

Files: 
CommentFileSizeAuthor
#8 drupal-reference-to-system-init-2023093-8.patch831 bytesnguerrero
PASSED: [[SimpleTest]]: [MySQL] 56,952 pass(es).
[ View ]
#6 drupal-reference-to-system-init-2023093-6.patch807 bytesnguerrero
PASSED: [[SimpleTest]]: [MySQL] 58,538 pass(es).
[ View ]
#6 drupal-reference-to-system-init-2023093-6.interdiff.txt733 bytesnguerrero
#4 drupal-reference-to-system-init-2023093-4.patch808 bytesgiammi
PASSED: [[SimpleTest]]: [MySQL] 58,077 pass(es).
[ View ]
#4 drupal-reference-to-system-init-2023093-4.interdiff.txt734 bytesgiammi
#2 drupal-reference-to-system-init-2023093-2.patch616 bytesnguerrero
PASSED: [[SimpleTest]]: [MySQL] 57,963 pass(es).
[ View ]

Comments

jhodgdon’s picture

Thanks for the report! I used grep and found that these are normally now added in system_page_build().

So, sounds like a good novice project to fix up this code comment -- oh, I see you've already tagged the issue. :)

nguerrero’s picture

Status:Active» Needs review
StatusFileSize
new616 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,963 pass(es).
[ View ]

I searched the string and is not used for what I chose to delete this comment, because the cast was obsolete information.

A greeting!

jhodgdon’s picture

Status:Needs review» Needs work

But... Those CSS files are normally added by system_page_build(), as noted in comment #1. Why not change the code comment to say that?

giammi’s picture

Status:Needs work» Needs review
StatusFileSize
new734 bytes
new808 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,077 pass(es).
[ View ]

trying...

jhodgdon’s picture

Status:Needs review» Needs work

Thanks! This patch is better... but there are a couple of issues:
- The information in the original comment "except maintenance.css" was lost.
- There is a space at the end of the first line. If you plan to work on Drupal patches (and I hope you will continue!) see if you can either set up your editor to remove spaces at the end of lines, or at least highlight them.

nguerrero’s picture

StatusFileSize
new733 bytes
new807 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,538 pass(es).
[ View ]

try :)

nguerrero’s picture

Status:Needs work» Needs review

forget change status sorry.

nguerrero’s picture

StatusFileSize
new831 bytes
PASSED: [[SimpleTest]]: [MySQL] 56,952 pass(es).
[ View ]

add "-except maintenance.css."

:)

giammi’s picture

Thanks for your feedback.

penyaskito’s picture

Status:Needs review» Reviewed & tested by the community

After feedback has been addressed I think we can RTBC this one.

jhodgdon’s picture

Status:Reviewed & tested by the community» Fixed

Thanks! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.