Better message when failing to write file [#2023031]

If drupal_debug() tries to write to file and fails the error is simply "The file could not be written.". It would be nice if this at least said that this was from the devel module to help debug the problem quickly. Patches to follow.

Comment	File	Size	Author
#9	devel-8.x-2023031-debug-file-error-9.patch	556 bytes	justanothermark
#9
#8	devel-8.x-2023031-debug-file-error-8.patch	555 bytes	justanothermark
#8
#6	devel-2023031-debug-file-error-6.patch	556 bytes	justanothermark
#6
#4	devel-debug-file-error-4.patch	0 bytes	justanothermark
#4
#2	devel-7.x-1.x-debug-file-error-2023031-2.patch	544 bytes	justanothermark
#2
#1	devel-7.x-1.x-debug-file-error-2023031-1.patch	541 bytes	justanothermark
#1
#1	devel-8.x-1.x-debug-file-error-2023031-1.patch	544 bytes	justanothermark
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

justanothermark CreditAttribution: justanothermark commented 19 June 2013 at 09:22

Status:

Active

» Needs review

File	Size
devel-8.x-1.x-debug-file-error-2023031-1.patch	544 bytes

devel-7.x-1.x-debug-file-error-2023031-1.patch	541 bytes

Patches for 7.x-1.x and 8.x-1.x attached.

Comment #2

justanothermark CreditAttribution: justanothermark commented 19 June 2013 at 09:29

File	Size
devel-7.x-1.x-debug-file-error-2023031-2.patch	544 bytes

Oops, new message was inconsistent between branches. Fixed 7.x-1.x patch.

Comment #3

salvis

he/his

CreditAttribution: salvis commented 19 June 2013 at 22:11

+++ b/devel.module
@@ -1679,7 +1679,7 @@ function drupal_debug($data, $label = NULL) {
-    drupal_set_message(t('The file could not be written.'), 'error');
+    drupal_set_message(t('The debug file could not be written to by Devel.'), 'error');

Can we use active voice? Something like "Devel was unable to write to %file."

Comment #4

justanothermark CreditAttribution: justanothermark commented 19 June 2013 at 23:22

File	Size
devel-debug-file-error-4.patch	0 bytes

Sounds good to me. I'll admit that I wasn't completely happy with the message I suggested but hadn't thought about the alternatives & just made the simplest change to get the info in there. 7.x patch with new message attached.