The views handler generates an incorrect path if Drupal is in a subdirectory e.g. http://example.com/drupal/node/1 generates http://example.com/drupal/drupal/node/1. Patch attached. This handler doesn't work still though because it's still using sharethis_get_button_HTML(). I could re-roll once #2018005-5: Warning: Invalid argument supplied for foreach() in theme_sharethis() (line 426 is committed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gaofengzzz’s picture

Status: Needs review » Reviewed & tested by the community

Thank you, very nice patch. I think this is best practise to get absolute path. Change status to RTBC.

Gaofengzzz’s picture

Status: Reviewed & tested by the community » Needs work

Alright, it seems there are some other place in module file probably need this kind of replacement. @dsdeiz, could you help check the places in the module. Thanks very much for any feedback or comment on this issue.

dsdeiz’s picture

Others look fine to me. They are already using url(...). sharethis_node_view() could do some cleaning though but I've already posted a patch at #2019825: Clean up some parts in sharethis_node_view()..

dsdeiz’s picture

Status: Needs work » Needs review
FileSize
526 bytes

Re-rolling.

Gaofengzzz’s picture

It is commited in 47a6f84. Thanks for your contribution.

Gaofengzzz’s picture

Status: Needs review » Fixed

Forget to change status.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.