Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The views handler generates an incorrect path if Drupal is in a subdirectory e.g. http://example.com/drupal/node/1
generates http://example.com/drupal/drupal/node/1. Patch attached. This handler doesn't work still though because it's still using sharethis_get_button_HTML()
. I could re-roll once #2018005-5: Warning: Invalid argument supplied for foreach() in theme_sharethis() (line 426 is committed.
Comment | File | Size | Author |
---|---|---|---|
#4 | incorrect-path-views-subdirectory-3.patch | 526 bytes | dsdeiz |
incorrect-path-views-subdirectory.patch | 605 bytes | dsdeiz | |
Comments
Comment #1
Gaofengzzz CreditAttribution: Gaofengzzz commentedThank you, very nice patch. I think this is best practise to get absolute path. Change status to RTBC.
Comment #2
Gaofengzzz CreditAttribution: Gaofengzzz commentedAlright, it seems there are some other place in module file probably need this kind of replacement. @dsdeiz, could you help check the places in the module. Thanks very much for any feedback or comment on this issue.
Comment #3
dsdeiz CreditAttribution: dsdeiz commentedOthers look fine to me. They are already using
url(...)
.sharethis_node_view()
could do some cleaning though but I've already posted a patch at #2019825: Clean up some parts in sharethis_node_view()..Comment #4
dsdeiz CreditAttribution: dsdeiz commentedRe-rolling.
Comment #5
Gaofengzzz CreditAttribution: Gaofengzzz commentedIt is commited in 47a6f84. Thanks for your contribution.
Comment #6
Gaofengzzz CreditAttribution: Gaofengzzz commentedForget to change status.