Basic theme settings for menu/mobile rendering [#2020135]

Dealing with different Foundation navigation systems and having the theme implement navigation in an easy and straight forward way has been an issue. Examples of this can be found at #1825876: How to use Foundation Navigation?, #1934076: Support top-bar rather than nav-bar , #2018739: Top bar broken in STARTER template.php. Alexweber had a cool simple theme setting to handle this but at the same time we want to avoid adding too much complexity.

Suggestions or feedback welcome otherwise my vote goes to adding a simple theme configuration.

Comment	File	Size	Author
#10	Screen shot 2013-06-21 at 8.45.19 AM.png	242.42 KB	damiandab
#8	Selection_001.png	55.19 KB	chrisjlee
#7	zurb-foundation-top-bar-setting-2020135-7.patch	9.39 KB	chrisjlee
#5	zurb-foundation-top-bar-setting-2020135-5.patch	10.26 KB	alexweber
#2	zurb-foundation-top-bar-setting-2020135-2.patch	7.9 KB	alexweber

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

alexweber CreditAttribution: alexweber commented 14 June 2013 at 22:38

Assigned:

Unassigned

» alexweber

Comment #2

alexweber CreditAttribution: alexweber commented 15 June 2013 at 00:16

Status:

Active

» Needs review

File	Size
zurb-foundation-top-bar-setting-2020135-2.patch	7.9 KB

This one is a pretty simple change but big in that it affects a few different files so please review it and let me know if it's good to commit!

Thanks

Comment #3

chrisjlee CreditAttribution: chrisjlee commented 15 June 2013 at 21:15

+++ b/STARTER/templates/page.tpl.phpundefined
+<!-- Top bar -->
+<?php if ($zurb_foundation_top_bar): ?>
+  <div class="<?php if ($zurb_foundation_animate) { print 'animated '; print $zurb_foundation_animate; } ?><?php if ($zurb_foundation_top_bar == 2) print ' show-for-small'; ?>">

One small nitpick and more of a question. Should this conditional logic be placed in a template file?

Comment #4

alexweber CreditAttribution: alexweber commented 15 June 2013 at 22:44

@chris, good call man, I'm gonna move that to the preprocess instead

Comment #5

alexweber CreditAttribution: alexweber commented 17 June 2013 at 22:05

File	Size
zurb-foundation-top-bar-setting-2020135-5.patch	10.26 KB

New patch attached with the following changes:

Moved extraneous logic from page.tpl.php to template.php
Added extra settings for main top bar config: contain to grid, sticky and also for mobile menu text

Comment #6

alexweber CreditAttribution: alexweber commented 20 June 2013 at 17:11

Has anyone had a chance to look at this? I've got an itchy trigger finger to commit this and address eventual changes as follow-ups... this branch is in dev anyway right? :)

Comment #7

chrisjlee CreditAttribution: chrisjlee commented 20 June 2013 at 20:33

Assigned:	alexweber	» Unassigned
Status:	Needs review	» Fixed

File	Size
zurb-foundation-top-bar-setting-2020135-7.patch	9.39 KB

Reroll attached. Committed..

Great work! http://drupalcode.org/project/zurb-foundation.git/commit/cc9a847

Comment #8

chrisjlee CreditAttribution: chrisjlee commented 20 June 2013 at 20:35

File	Size
Selection_001.png	55.19 KB

Forgot to attach new fun screenshots:

Thanks Alex!

Comment #9

alexweber CreditAttribution: alexweber commented 20 June 2013 at 22:30

woohooo!!! :)

Comment #10

damiandab CreditAttribution: damiandab commented 21 June 2013 at 06:50

File	Size
Screen shot 2013-06-21 at 8.45.19 AM.png	242.42 KB

Could someone explain me please how I get to work mobile menu bar? I click on menu and nothing happen.
I don't see also my menu items. Screenshot attached.

Best,
Damian

Comment #11

damiandab CreditAttribution: damiandab commented 21 June 2013 at 07:18

Priority:	Normal	» Major
Status:	Fixed	» Active

In mobile-mode clicking on the button [menu] nothing happens; the menu-items don't appear.

Comment #12

alexweber CreditAttribution: alexweber commented 21 June 2013 at 11:35

@damiandab Please don't cross post! This issue is only for adding the settings. You already mentioned this isn't working here: #2022631: Top Bar Menu doesn't inject class "expanded" in code when clicked

Thanks

Comment #13

alexweber CreditAttribution: alexweber commented 21 June 2013 at 11:35

Priority:	Major	» Normal
Status:	Active	» Fixed

As far as adding new settings go, everything's fine!

Let's follow-up in the other issue.

Comment #14

damiandab CreditAttribution: damiandab commented 21 June 2013 at 12:19

Hi Alex,

I'm sorry for crossing. I will follow another post you mentioned.

Best,
Damian

Comment #15

5 July 2013 at 12:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #16

paskainos CreditAttribution: paskainos commented 2 December 2013 at 03:43

Sorry for cross-posting. I found shumushin's #2005236: Menu rendering implementation first, and then I found this post. Is there a prescribed method / best practice for adding the 'button' class to links in the alt_main_menu and / or alt_secondary_menu 'menus'? @shumushin's patch from the aforementioned issue (although for D8) looks promising to that end. Any ideas?

Comment #17

paskainos CreditAttribution: paskainos commented 22 April 2014 at 18:39

Issue summary:

View changes

Hey Alex, I was wondering if it would make sense to add a fixed / sticky option (or ?) for the top bar. The primary reason being, when the top bar (i.e. main / secondary menu(s)) is positioned at page top always, the styling changes on scrolling when the 'sticky' class is removed, and the 'fixed' class is added. In order to maintain consistent styling, I changed 'sticky' to 'fixed' in the sub-theme template.php file. But I was curious what your thoughts on protocol were.