Follow up for #2004428-16: Less ugly operations altering

Updated: Comment #0

Problem/Motivation

the roles (and user) page is broken with:
LogicException: Unable to parse the controller name "user_admin". in Drupal\Core\Controller\ControllerResolver->createController() (line 91 of /Users/ctheys/foo/drupal/core/lib/Drupal/Core/Controller/ControllerResolver.php).
The website has encountered an error. Please try again later.

It is ok in drupal 8.x, but in config_translation, it's not.

Proposed resolution

?

Remaining tasks

  • confirm
  • discuss cause

User interface changes

No.

API changes

No.

Files: 
CommentFileSizeAuthor
#6 config_translation-2019831-6.patch1.52 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 378 pass(es). View
#2 role_translation.png12.62 KBdawehner
#2 config_translation-2019831-2.patch1.51 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation-2019831-2.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

YesCT’s picture

I thought this #2010290: Editing a config entity from a listing page results in a 'page not found'
might help.
But it did not seem to have an effect.

dawehner’s picture

Status: Active » Needs review
FileSize
1.51 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation-2019831-2.patch. Unable to apply patch. See the log in the details link for more information. View
12.62 KB

This worked for me, see screenshot.
role_translation.png

Gábor Hojtsy’s picture

Issue tags: -D8MI, -language-config

#2: config_translation-2019831-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D8MI, +language-config

The last submitted patch, config_translation-2019831-2.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
Issue tags: +Needs tests

I sent this for a test re-run to ensure it still passes with all the added new tests. Also asked @kfritsche to add test coverage to continue #2004710: Add tests for block, menu, vocabulary and views listings with adding tests here for user roles.

Gábor Hojtsy’s picture

FileSize
1.52 KB
PASSED: [[SimpleTest]]: [MySQL] 378 pass(es). View

It only applied with a fuzz now.

Gábor Hojtsy’s picture

Status: Needs review » Fixed
Issue tags: -Needs tests

Committed this one with the test coverage devised in [#3037587], yay! Hiperyay! The commit message used was:

Issue #2027587 by kfritsche, David Hernández, dawehner, YesCT: Add tests for custom blocks, contact forms, formats, shortcut listings and settings pages.; fix for user roles from #2019831 included, otherwise tests would not pass; yay

That solved needing tests.

Automatically closed -- issue fixed for 2 weeks with no activity.