Complete Configuration schemas for views row

I have added configuration of EntityRow.php and RssFields.php in core/modules/views/config/schema/views.row.schema.yml

Patch updated. Please review.

#5: views-row-configuration-schemas-for-views-row-2019091-4.patch queued for re-testing.

This config will not exist on a fresh install of Drupal.

The RssFields.php settings can be accessed by editing the feed display of a view, e.g. add /admin/structure/views/view/frontpage/edit/feed_1. Under FORMAT, ensure Format: is RSS Feed, and Show: is Fields. These options are then on the following settings form.

In my testing the options were saved but were not exported, so there may be a bug there.

@ianthomas_uk Can you please verify whether this issue needs some work?

I can't reproduce the problem I was having before (I think I meant that my changes were showing in the UI, but had no effect on the config files).

In #11 the schema for views.row.rssfields reflected the types of data that would be returned in the RSS feed, but it should actually represent where this data should come from (so most of the settings are field names). I've attached an updated patch that corrects this.

I'm not sure how to EntityRow, as I couldn't work out how to create an appropriate view. I think it's intended as a base class and doesn't have any implementations in core. The schema's definitely wrong though, as it's based on the variables in init() instead of defineOptions().

Thanks @vijaycs85. I thought it should probably just be removed but needed a second opinion. I've updated the summary to reflect this.

I can confirm that #15 is my patch from #14 minus the changes for EntityRow.php.
If you review my changes for RssFields.php are we able to mark this RTBC between us, or do we need a third person?

So, does that mean that something like entity_row:node won't have properties, as it is automatically added via the derivative class?

Thanks dawehner.

Looking at this again, the views module should provide the schema for the view_mode option, and each of the Comment and Node modules should provide the schema for the links option (which they define independently). The action module has an example of a module extending the schema of another.

To expose the configuration for NodeRow I set Format: HTML list, Show: Content.

Here's an improved patch: I've corrected the key for rss fields and added the EntityRow schemas. Node and comment seem to be working, but user is still showing as unknown in the config inspector and I'm not sure why. I've also spotted lots more classes that extend RowPluginBase that I think we need to provide schema for (listed in the summary).

The patch files might help...

I can't RTBC this patch as I wrote lots of it, but I did want to mention a couple of things in vijaycs85's changes.

1. --- /dev/null
   +++ b/core/modules/comment/config/schema/comment.view.schema.yml
   

   vijaycs85 explained that this matches the filename convention for schema files. I'm happy to follow the convention, but this is different to the pattern used to provide default config where the filename would start with the name of the module that you were extending and be in the module that is doing the extending, so it is only available if both are installed.

2. +++ b/core/modules/node/config/schema/node.view.schema.yml
   @@ -0,0 +1,15 @@
   +# Schema for the views plugins of the Views module.
   

   +1 for the comment, but it should be Node module.

Yeah let's mark this as work, though at the same time think about adding a follow up to support the usecase here for schema as well.