part of #2011290: [meta] standards cleanup to get ready for getting into core
Clean up the following file:
http://drupalcode.org/project/config_translation.git/blob/HEAD:/lib/Drup...

Proposed resolution

Remaining tasks

User interface changes

No

API changes

No

Files: 
CommentFileSizeAuthor
#1 config_translation.code_subscriber.2017987-1.patch1.59 KBYesCT
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.code_subscriber.2017987-1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

YesCT’s picture

Title: lib/Drupal/config_translation/Routing/RouteSubscriber.php standards cleanup to get ready for getting into core » RouteSubscriber.php standards cleanup to get ready for getting into core
Status: Active » Needs review
FileSize
1.59 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch config_translation.code_subscriber.2017987-1.patch. Unable to apply patch. See the log in the details link for more information. View

$depth = substr_count($path, '/');
was an unused variable

some whitespace, newlines.

a verb tense on a method doc line

and an inheritdoc

Gábor Hojtsy’s picture

Status: Needs review » Fixed

Thanks, looks good!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.