Added options for opacity, point radius, label outline, label color and label opacity for all three states.

Files: 
CommentFileSizeAuthor
#3 cluster_style_options_stroke.patch9.72 KBcaktux
PASSED: [[SimpleTest]]: [MySQL] 225 pass(es).
[ View ]
cluster_style_options.patch8.27 KBcaktux
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch cluster_style_options.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, cluster_style_options.patch, failed testing.

Pol’s picture

Hi,

This could be a great patch but it still needs work.

  1. See why the testbot failed, why the patch doesn't apply correctly ?
  2. Add a small description of each added fields and what's the default value in the description.
  3. I think the JS part needs to cast value. If you set a string for an integer, it might crash.

Thanks !

caktux’s picture

Status:Needs work» Needs review
StatusFileSize
new9.72 KB
PASSED: [[SimpleTest]]: [MySQL] 225 pass(es).
[ View ]

Testbot needs git patches... Added stroke color options.

Pol’s picture

Excellent patch, I'll review all of this when I have a bit more time, probably at the Drupalcamp Dublin.

Thank you very much !

Status:Needs review» Needs work

The last submitted patch, cluster_style_options_stroke.patch, failed testing.

acbramley’s picture

Status:Needs work» Needs review

#3: cluster_style_options_stroke.patch queued for re-testing.

acbramley’s picture

Woo, tests now pass with the latest dev release. We needed this for IE compatibility for our cluster styling. Applies cleanly to latest dev release. Thanks a lot

Pol’s picture

Status:Needs review» Fixed

Thank you very much, committed !

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.