When a user hits the node edit form and has no available domains options, lots of errors are displayed. This is caused by bad usage of drupal_access_denied() in domain_form_alter().

CommentFileSizeAuthor
#1 domain-nodeform-errors-2017023-1.patch551 bytespeterpoe
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

peterpoe’s picture

peterpoe CreditAttribution: peterpoe commented
Status: Active » Needs review
FileSize
domain-nodeform-errors-2017023-1.patch551 bytes

Here be patches.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented

Patch follows the core pattern here:

https://api.drupal.org/api/drupal/modules!contact!contact.pages.inc/func...

peterpoe’s picture

peterpoe CreditAttribution: peterpoe commented
Issue summary: View changes
Status: Needs review » Fixed

Looks like it was fixed somewhere in time.

peterpoe’s picture

peterpoe CreditAttribution: peterpoe commented
Status: Fixed » Reviewed & tested by the community

Please ignore previous comment. Bug is still present in dev.
Marking as Reviewed since fix is trivial.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard as a volunteer commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

I cannot replicate this error.

peterpoe’s picture

peterpoe CreditAttribution: peterpoe commented
Status: Postponed (maintainer needs more info) » Needs review

If the user has the permission to "publish to any assigned domain" but has no assigned domain, the module will execute return drupal_access_denied(); which means nothing and will break the page. Proposed patch solves the issue.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard as a volunteer commented
Status: Needs review » Fixed

Committed.

e7041a4..fcdd3d4 7.x-3.x -> 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.