If you have a domain like foodev.org or bardevel.org, it will trigger the "dev" mode, because we require the dot only after dev
or devel
keyword. This is a wrong behaviour, because when triggered unintentionally, it may cause a major confusion, because the "dev" mode does various things to caching levels and settings, not to mention enabling all PHP errors on screen (security!)
The "dev" mode is intended to be used basically only for easy WSOD debugging, and maybe quick theming fixes, as it allows you to stop hardcoding CSS/JS aggregation on the fly (btw: it doesn't disable aggregation - it just stops hardcoding it as enabled).
We should fix this by introducing more strict requirement, so foodev.org or bardevel.org will no longer trigger "dev" mode. It should be required to create subdomain like bar.dev.foodev.org or foo.devel.bardevel.org to trigger the "dev" mode (so there is also a dot directly *before* and not only after the keyword).
Comment | File | Size | Author |
---|---|---|---|
#9 | barracuda.cnf_.txt | 1.8 KB | wickwood |
#9 | barracuda_log.txt | 8.93 KB | wickwood |
Comments
Comment #1
omega8cc CreditAttribution: omega8cc commentedFixed in commit: http://drupalcode.org/project/barracuda.git/commit/fa29aeb
Comment #2
omega8cc CreditAttribution: omega8cc commentedFix applied also to current stable.
Comment #4
omega8cc CreditAttribution: omega8cc commentedWe could also allow
^dev.
-- at least as long as there is another dot. Still, this could cause (edge case) problem for (TLD) domains likedev.org.foo
so not sure if we want to open this hole again.Comment #5
wickwood CreditAttribution: wickwood commentedTotally your call as I stated in comment #2 of the duplicate issue Help! I can't turn off the Forced Cacheing on any of my dev sites - what changed?
Regardless of what you choose to do, someone will probably have to make a change as to how they do things and I've already started making changes work with this new policy.
I'm just surprised I missed this this issue as I try to read every new issue that gets posted here just so I can be aware of changes like this. Oh well, as my mother always said, "the best laid plans are always shot to hell!"
Steve
Comment #6
omega8cc CreditAttribution: omega8cc commentedWe have added support for
^dev.
prefix in this commit: http://drupalcode.org/project/barracuda.git/commit/244f94c since TLDs like dev.org.foo seems to be pretty unrealistic edge case.Comment #7
wickwood CreditAttribution: wickwood commentedThanks! You are very kind to take time to do so and I think you are correct that dev.org.foo is pretty unrealistic edge case.
Comment #9
wickwood CreditAttribution: wickwood commentedSorry to reopen this issue, but I did upgrades on my BOA system yesterday and now I cannot uncheck "Cache pages for anonymous users" on the performance configuration for any version of a dev subdomain.
I have tried a.dev.domain.com, dev.a.domain.com, devel.a.domain.com, a.devel.domain.com and none of them will allow me to uncheck "Cache pages for anonymous users" on the performance configuration.
When I ran my upgrade yesterday, I did not upgrade the Aegir Master Instance. So I ran the BOA upgrade again today but this time I did upgrade the Aegir Master Instance, however this didn't help (and I didn't think it would, but thought I should try everything I can think of before submitting this issue).
Attached are /var/log/barracuda_log.txt and /root/.barracuda.cnf files.
Thanks for your help in advance!
Steve
Comment #10
omega8cc CreditAttribution: omega8cc commentedRight, some other commits re-ordered some checks and it broke things completely. Fixed in http://drupalcode.org/project/barracuda.git/commit/7bcbcf5 (and also in stable). Thanks for the heads up!
~Greg
Comment #11
wickwood CreditAttribution: wickwood commentedThanks Greg. It works except for devel.a.domain.com, which I don't think it is suppose to.
Steve
Comment #12
omega8cc CreditAttribution: omega8cc commentedCorrect, ^devel. will not work. We have added exception only for ^dev. Make sure to read: http://omega8.cc/how-to-disable-all-caching-and-aggregation-115
~Greg