Convert variable_set() and variable_get() calls to config system.

Change notice is here: http://drupal.org/node/1667896

Files: 
CommentFileSizeAuthor
#4 config_system-2012360-4.patch3.19 KBplopesc
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch config_system-2012360-4.patch. Unable to apply patch. See the log in the details link for more information. View
#1 config_system-2012360-1.patch20.36 KBplopesc
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch config_system-2012360-1.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

plopesc’s picture

Status: Active » Needs review
FileSize
20.36 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch config_system-2012360-1.patch. Unable to apply patch. See the log in the details link for more information. View

Patch that converts variables to new config system in Twitter module.

You can validate it checking that values in admin/config/services/twitter/settings page are stored successfully.

Regards

pcambra’s picture

Version: 7.x-6.x-dev » 8.x-1.x-dev
juampynr’s picture

Status: Needs review » Fixed
plopesc’s picture

Status: Fixed » Needs review
FileSize
3.19 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch config_system-2012360-4.patch. Unable to apply patch. See the log in the details link for more information. View

Patch improved.

Now module handler and config factory are included through dependency injection.

Regards.

DamienMcKenna’s picture

Issue summary: View changes
Status: Needs review » Needs work

Triggering the testbot.

DamienMcKenna’s picture

Status: Needs work » Needs review

Triggering the testbot.

The last submitted patch, 1: config_system-2012360-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: config_system-2012360-4.patch, failed testing.

DamienMcKenna’s picture

Title: [Drupal 8]Convert twitter variables to config system » [Drupal 8] Convert twitter variables to config system

Can you please reroll the patch? Thanks.

DamienMcKenna’s picture

Assigned: plopesc » Unassigned
Status: Needs work » Closed (works as designed)

This code no longer applies as the module was rewritten in 2014.