Problem/Motivation

Since we want to get config translation into core, we need to make sure it meets the core gates. To make the chunks manageable, one issue per file.

Proposed resolution

Per core-gates standards, please add docs and standards fixes for each of the below issues. References to the standards:
https://drupal.org/core-gates#documentation
https://drupal.org/core-gates#documentation-block-requirements

Remaining tasks

review issues
work on those that need work

#2038743: docs cleanup use configuration instead of config
#2028127: clean up property names to be camel case instead of underscore separated words to cleanup to get ready for getting into core

./config_translation.admin.css #2011294: config_translation.admin.css standards cleanup to get ready for getting into core
./config_translation.api.php #2011320: config_translation.api.php hooks standards cleanup to get ready for getting into core
./config_translation.info.yml - Looks OK.
./config_translation.module #2011348: config_translation.module standards cleanup to get ready for getting into core
./config_translation.services.yml #2017887: config_translation.services.yml standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/Access/ConfigNameCheck.php #2017969: ConfigNameCheck.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/ConfigEntityMapper.php #2017975: ConfigEntityMapper.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/ConfigGroupMapper.php #2017977: ConfigGroupMapper.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/ConfigMapperInterface.php #2017979: ConfigMapperInterface.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/Controller/ConfigTranslationController.php #2017981: ConfigTranslationController.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/Form/ConfigTranslationDeleteForm.php #2017983: ConfigTranslationDeleteForm.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/Form/ConfigTranslationManageForm.php #2017985: ConfigTranslationManageForm.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/Routing/RouteSubscriber.php #2017987: RouteSubscriber.php standards cleanup to get ready for getting into core
./lib/Drupal/config_translation/Tests/ConfigTranslationUITest.php #2017989: ConfigTranslationUITest.php standards cleanup to get ready for getting into core

User interface changes

No.

API changes

No.

Comments

YesCT’s picture

Issue summary: View changes

list files

YesCT’s picture

Issue summary: View changes

added css issue

YesCT’s picture

Issue summary: View changes

added hook issue

YesCT’s picture

Issue summary: View changes

added module issue

YesCT’s picture

Issue summary: View changes

mark info.yml as ok

robertdbailey’s picture

Issue summary: View changes

additional info to description to include core-gates references

robertdbailey’s picture

Issue summary: View changes

added link to child issue

robertdbailey’s picture

Issue summary: View changes

added links to subtasks for each file

YesCT’s picture

Issue summary: View changes

tricking the [#...] to reload for easier reading.

YesCT’s picture

Issue summary: View changes

updated remaining tasks

YesCT’s picture

Assigned: YesCT » Unassigned

all the initial ones are done.

here is another brought up:
#2038743: docs cleanup use configuration instead of config

We could probably use a look over everything from someone looking with new eyes. Maybe we could ping someone specific and ask them to take a look.

YesCT’s picture

Issue summary: View changes

added one for camelCase of properties on classes.

Gábor Hojtsy’s picture

Status: Active » Fixed

Looks like all the subissues listed are closed. Closing this down.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

YesCT’s picture

if we wanted to be really picky (which is not a core blocking gate) we could take out the period at the end of @see, and make sure namespaces in comments (like in @see's) have a beginning \ https://drupal.org/node/1354#see

Gábor Hojtsy’s picture

The dots on @see were removed earlier. The \ for @see is now fixed at http://drupalcode.org/project/config_translation.git/commitdiff/5781a9e2...

Gábor Hojtsy’s picture

Issue summary: View changes

new one for configuration instead of config