Replace theme() with drupal_render() in dblog module

We are working today with this issue during Code Sprint UA.

Patch attached.

#3 nice
RTBC

Shouldn't these be format_username()?

If we still want the linking functionality, I think it needs to be called from theme_username() instead of calling user_format_name() here, right? Let's leave this as-is and fix that if this is an issue. Follow up: #2019305: Call user_format_name from theme_username

+++ b/core/modules/dblog/lib/Drupal/dblog/Controller/DbLogController.phpundefined
@@ -169,7 +173,7 @@ public function overview() {
-          theme('username', array('account' => $dblog)),
+          drupal_render($username),

I don't think we need to use drupal_render here...
just replacing this with...

array(
  '#theme'=>'username',
  '#account'=> $dblog,
)

Should work...

Giving it a shot.

Error Message I received was:
HTTP response expected 200, actual 500 Browser DbLogTest.php 256

Checked the DbLogTest.php which gave
// View the database log report.
$this->drupalGet('admin/reports/dblog');

running /admin/reports/dblog gave me message
Fatal error: Call to undefined method stdClass::printed() in /home/giammi/coding/drupal/core/lib/Drupal/Core/Template/Attribute.php on line 105

Hope somebody else can take over.

Let's give this a try.

#11: drupal-dblog-drupalRender-2008990-11.patch queued for re-testing.

Applied the patch and everything running smoothly. Revised code and I like it.

Just a minor code style nit... otherwise looks great.

+++ b/core/modules/dblog/dblog.admin.incundefined
@@ -97,6 +97,10 @@ function dblog_event($id) {
+    $username = array(
+      '#theme'=>'username',
+      '#account'=> $dblog,
+    );

+++ b/core/modules/dblog/lib/Drupal/dblog/Controller/DbLogController.phpundefined
@@ -162,6 +162,10 @@ public function overview() {
+      $username = array(
+        '#theme'=>'username',
+        '#account'=> $dblog,
+      );

Missing some spaces... should be like this

    $username = array(
      '#theme' => 'username',
      '#account' => $dblog,
    );

I missed that in the re-roll. Let's see how this flies.

@heddn changing status 'needs review', so test will run.

I followed the instructions to test this code. I went to the list under recent log messages under reports, and I saw the messages. When I clicked on the message, I saw the same warnings. This code seems to work just fine.

Committed d97d1aa and pushed to 8.x. Thanks!