Well , this is quite unfortunate.
Yesterday I updated the Metatag module to beta7. Everything seemed fine, but when my client started editing pages it showed that all the metatags she had entered on the nodes to override the set patterns are gone ... and on all pages it just says "using defaults" where there used to be custom entered tags.

Tagged this as major since this looks pretty scary as the amount of work that went into entering all the metatags runs almost upto a week work.

Would love to hear feedback on this.
If you need more info, let me know, I will obviously kindly provide.

CommentFileSizeAuthor
#4 metatag_error.png5.06 KBsunchaser
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Did you run the database updates? What version were you using before you updated?

sunchaser’s picture

Hi Damien,

First off , thanks for your quick response.

Answering your questions:
1) yes, I ran all database updates
2) version installed before update : "7.x-1.0-beta1"

Cheers,

sunchaser’s picture

I should add that I'm on a multilingual install.

I see that as of Beta7 there is an extra field added in the metatag table called "language"
The beta1 didn't seem to have that.

Obviously , the field "language" is empty in all instances.

Is this a possible entrypoint to an explanation for what happened?

sunchaser’s picture

FileSize
5.06 KB

metatag error

(apologies for the fragmented feedback here - posting as I go - trying to help to move this issue forward as soon as possible)

TEST 1:
- Added a new node and have overriden the metatags
- Metatags saved perfectly

TEST 2:
- Added the language parameter value "fr" into a random French record inside the metatag table
- Custom metatags were picked up again for that specific node.
(don't tell me I need to get into every node now and add a language value for all of them manually :D :/)

Check above screenshot from db entry. Language param has been (correctly) added... language param empty for all other nodes that were already there ...

sunchaser’s picture

To get a head start on a solution from module creator I threw together a quick "merge script" to fill up the empty values for the language field in the metatag table.

(did a check on language from node tables and matched them with the entity id entries in metatag table)

btw, this seems related from an earlier version : http://drupal.org/node/1842868

DamienMcKenna’s picture

Ok, so 7.x-1.0-beta1 only had updates 7001 and 7002, so the multilingual functionality hadn't been added yet.

Can you please take a look at the {metatag} table and let me know if the old data has correct language values?

sunchaser’s picture

yes,
As described in my comment in #5 I now added language codes to all entries in the {metatag} table.

Maybe I should open another issue for this - but possibly related so keeping it here for now (let me know if you want to split this up)

After having done the "language field fill-up in #5" I am now no longer getting metatags from the module in my pages (nodes, taxo pages, ...)

I have made sure that <?php print render($page['content']); ?> is on the page , but the
array $page['content']['metatags']); is just non-existent or just doesn't contain the metatags from the module.

The only instance where ['metatags'] has any data is on a certain content type (news) where the the "metatags" array looks like this:

 [metatags] => Array
 (
[nl] => Array
(
[title] => Array
(
  [value] => This is the title blah blah
)

[description] => Array
(
   [value] => This is the description blah blah
)
)
)

Possible this is not even being generated by the Meta Tag module ?!

Are there some debug steps you need me to setup so I can give you the right feedback on what's happening on my install ?
Thanks again for having a look at this.

extra notes:
- not using the display suite module
- not using panels

DamienMcKenna’s picture

First off, try changing over to Barik to see if that makes any difference.

Secondly, did any of the updates give errors? Did they all finish? Are you using Entity Translation?

sunchaser’s picture

I got out of bed again for this :) (its 4 am here) - can't get this out of my head.

answers to your questions:
- Changing over to Bartik did not yield any meta tags either
- updates did not give errors and they all finished
- yes , I am using Entity Translation (version 7.x-1.0-beta2)

I've currently also upgraded the Metatag module to our staging environment ... and there, we have no issues whatsoever. Metatags are being spit out fine (just like they were before) ... same version of Entity Translation on Staging environment too

other modules that are installed and may be relevant:
- Chaos tools 7.x-1.3
- Meta tags (quick) 7.x-2.7
- Token 7.x-1.5

sunchaser’s picture

this has been fixed
Will report back here about circumstances and reasons when I've had some rest, but it is safe to say that after the language fields were filled in correctly into the {metatag} table all was fine regarding this module.

I did have some internal issues that prevented the opengraph submodule from spitting out values.
This issue can be fixed , unless we still have to document the language value 'issue' I reported in the beginning of this thread.

DamienMcKenna’s picture

Title: Custom overriden metatags are all gone after module update » Make metatag_update_7011 work with EntityTranslation
Issue tags: +D7 stable release blocker

I suspect that the problem stems from metatag_update_7011 skipping the fix-the-languages step if EntityTranslation is installed; I had purposefully skipped that step in the interest if getting an existing patch to work and be able to roll out beta5, but it's time to fix it.

DamienMcKenna’s picture

Issue summary: View changes
Status: Active » Fixed

To all intends and purposes, this has been fixed by #1572474: Add Revisions to Metatags for Entities.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.