Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Discovered in connection with: #1914694: Errors appearing in testbot Error logs.
If you apply the minimal patch that asserts that we don't get a 500 from the drupalGet() after saving the feed after invoking the magical setter on its 'block' attribute, you will see that our way of mimicking this functionality is no good.
In other words, doing
$feed->block = 0;
$feed->save();
ostensibly causes Drupal to crash on the following request.
Comment | File | Size | Author |
---|---|---|---|
aggregator-0-items-broken-do-not-test.patch | 701 bytes | wamilton | |
Comments
Comment #9
quietone CreditAttribution: quietone as a volunteer commentedThe lines of code in the IS were removed from \Drupal\Tests\aggregator\Functional\AggregatorRenderingTest::testBlockLink in #1888702: Use configuration selection instead of derivatives for some blocks. I don't think there is anything to do here.
Added the issue in the IS to the related issues.
Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.
Thanks!