#1998116: Mixed types invoke notices. and #2003834: Accessibility fixes could both profit if the Fallback Language (Built-In English) is handled in ConfigGroupMapper

Files: 
CommentFileSizeAuthor
#6 2004194-config-translation-getLanguageWithFallback-6.patch1.1 KBSchnitzel
FAILED: [[SimpleTest]]: [MySQL] 238 pass(es), 2 fail(s), and 6 exception(s). View
#3 1999156-config-tranlation_accessibility-depends-2004194-9.patch3.15 KBSchnitzel
FAILED: [[SimpleTest]]: [MySQL] 193 pass(es), 53 fail(s), and 27 exception(s). View
#1 2004194-config-translation-getLanguageWithFallback-1.patch1010 bytesSchnitzel
PASSED: [[SimpleTest]]: [MySQL] 238 pass(es). View

Comments

Schnitzel’s picture

FileSize
1010 bytes
PASSED: [[SimpleTest]]: [MySQL] 238 pass(es). View

this patch ads getLanguageWithFallback(), when it has landed, #2003834: Accessibility fixes and #1998116: Mixed types invoke notices. can be updated

Schnitzel’s picture

Status: Active » Needs review
Schnitzel’s picture

FileSize
3.15 KB
FAILED: [[SimpleTest]]: [MySQL] 193 pass(es), 53 fail(s), and 27 exception(s). View

*ignoreme*

Status: Needs review » Needs work

The last submitted patch, 1999156-config-tranlation_accessibility-depends-2004194-9.patch, failed testing.

Gábor Hojtsy’s picture

+++ b/lib/Drupal/config_translation/ConfigGroupMapper.phpundefined
@@ -149,6 +149,22 @@ class ConfigGroupMapper implements ConfigMapperInterface {
+   * Returns the language of the configuration group, if there is no language
+   * found, returns a dummy English language
+   *

First comment should be 1 line.

Let's explain why do we do this :) Something like "If there is no language found and the original language code is 'en', we return a dummy English language to represent the built-in English language."

+++ b/lib/Drupal/config_translation/ConfigGroupMapper.phpundefined
@@ -149,6 +149,22 @@ class ConfigGroupMapper implements ConfigMapperInterface {
+   *   Language object with the language of the configuration group, or dummy
+   *   English fallback language if no language.
+   *

We can simplify this down to "A configured language object instance or a dummy English language object." Or something along those lines.

Schnitzel’s picture

Status: Needs work » Needs review
FileSize
1.1 KB
FAILED: [[SimpleTest]]: [MySQL] 238 pass(es), 2 fail(s), and 6 exception(s). View

update by Gabor and Me

Status: Needs review » Needs work

The last submitted patch, 2004194-config-translation-getLanguageWithFallback-6.patch, failed testing.

Gábor Hojtsy’s picture

Status: Needs work » Fixed

Thanks, committed! This will be useful in multiple issues!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.