file aggregator-item.html.twig:

<article {{ attributes }}>
  <h2><a href="{{ feed_url }}">{{ feed_title }}</a></h2>

  {% if content %}
      {{ content }}
  {% endif %}

  <footer>
    {% if source_url %}
      <a href="{{ source_url }}" class="feed-item-source">{{ source_title }}</a> -
    {% endif %}
    <time>{{ source_date }}</time>
    {% if categories %}
      <div>
        {{ 'Categories'|t }}: {{ categories|join(', ') }}
      </div>
    {% endif %}
  </footer>
</article>

the aggregator do build its own wrapper markup thats not effected by twig in function _aggregator_page_list which isnt ideal & makes it confusing that we cant change that part in the twig files.

 $build = array(
      '#type' => 'container',
      '#attributes' => array('class' => array('aggregator-wrapper')),
    );
Files: 
CommentFileSizeAuthor
#1 2003816-aggregator.diff2.16 KBmortendk

Comments

mortendk’s picture

Assigned: Unassigned » mortendk
Status: Active » Needs work
FileSize
2.16 KB

Removed the .feed-item
aggregator-item.html.twig is now html5
the categories have easier syntax for later costimyzation

mortendk’s picture

i get a little bit sad by seeing this in the aggregator.module:

function theme_aggregator_block_item($variables) {
  // Display the external link to the item.
  return '<a href="' . check_url($variables['item']->link) . '">' . check_plain($variables['item']->title) . "</a>\n";
}

should i open up a seperate issue for this or is it wiser we hammer it all out into one pathc ?

hrmoller’s picture

I think the container issue is on higher level than the aggregator.module itself as

$build = array(
      '#type' => 'container',
      '#attributes' => array('class' => array('some-class')),
    );

is used widely across core.

Regarding #2 do you think it would be sufficient to use the l() for creating the link?

twistor’s picture

+++ b/core/modules/aggregator/templates/aggregator-item.html.twig
@@ -18,27 +18,37 @@
+    {% for item in categories %}
+      {% if loop.first %}
+        {{ item }} ,
+      {% elseif loop.last %}
+        {{ item }}
+      {% else %}
+        {{ item }} ,
+      {% endif %}
+    {% endfor %}

This will have a trailing comma if there's only one category.

mortendk’s picture

Issue summary: View changes
Issue tags: -dreammarkup +dreammarkup. twigtemplate
mortendk’s picture

Issue tags: -dreammarkup. twigtemplate +dreammarkup, +Twigtemplate
mortendk’s picture

Issue tags: +Twig
ParisLiakos’s picture

@ #2:
#1763964: Use #type => link for theme_aggregator_block_item()
this should removed and be a #type => link i think

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.