Files: 
CommentFileSizeAuthor
#11 2003514_rename-view-method-mark_table_11.patch1.48 KBsomepal
PASSED: [[SimpleTest]]: [MySQL] 56,638 pass(es).
[ View ]
#3 drupal-camelcase-replace-2003514.3.patch1.48 KBbaldwinlouie
Test request sent.
[ View ]
#2 drupal-camelcase-replace-2003514-7451450.patch1.47 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

baldwinlouie’s picture

Assigned:Unassigned» baldwinlouie

taking it with sillygwailo

baldwinlouie’s picture

Status:Active» Needs review
StatusFileSize
new1.47 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

adding patch

baldwinlouie’s picture

StatusFileSize
new1.48 KB
Test request sent.
[ View ]

rerolling with access modifier

dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -466,7 +466,7 @@ function queue_table($table, $relationship = NULL, JoinPluginBase $join = NULL,
+  public function markTable($table, $relationship, $alias) {

I can't think of a reason why someone would need this as public method. Can you think of one?

aspilicious’s picture

Status:Needs review» Needs work

Should be protected :)

somepal’s picture

I couldn't find the reason to make it protected as well, this method has two calls from its own class' member. I guess it should be fine to keep it private.

aspilicious’s picture

NEVER make anything private inside views. there are 1000 use cases where you need to extend the classes defined in core. When you make function private it's a lot harder to extend these classes.

somepal’s picture

@aspilicious thank you, appreciate the quick response. you saved me, I was about to create patch as private.

baldwinlouie’s picture

Status:Needs work» Needs review

setting to needs review so someone can take a look at the latest patch

aspilicious’s picture

Status:Needs review» Needs work

public ==> protected.

I looked at the latest patch. Fix that and this is ok :)

somepal’s picture

Status:Needs work» Needs review
StatusFileSize
new1.48 KB
PASSED: [[SimpleTest]]: [MySQL] 56,638 pass(es).
[ View ]

@aspilicious ok.so re-rolling patch in #3 as protected

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Thank you!

somepal’s picture

no problem :)

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2003514_rename-view-method-mark_table_11.patch, failed testing.

dawehner’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
somepal’s picture

thank you!

heddn’s picture

Status:Needs review» Reviewed & tested by the community

Applies cleanly and all mentions of mark_table are gone.

somepal’s picture

Thanks for review!

webchick’s picture

Title:Rename Views method mark_table() to markTable()» Change notice: Rename Views method mark_table() to markTable()
Project:Drupal core» Views
Version:8.x-dev» 8.x-3.x-dev
Component:views.module» Code
Status:Reviewed & tested by the community» Active
Issue tags:+Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

Title:Change notice: Rename Views method mark_table() to markTable()» Rename Views method mark_table() to markTable()
Project:Views» Drupal core
Version:8.x-3.x-dev» 8.x-dev
Component:Code» views.module
Assigned:baldwinlouie» Unassigned
Status:Active» Fixed
Issue tags:-Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.