Files: 
CommentFileSizeAuthor
#9 views-core-operator_validate-2003460-9.patch1.11 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,174 pass(es).
[ View ]
#7 views-core-operator_validate-2003460-7.patch1.11 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] 56,043 pass(es), 2 fail(s), and 1 exception(s).
[ View ]
#2 drupal-camelcase-replace-2003460-7451340.patch1.09 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

baldwinlouie’s picture

Assigned:Unassigned» baldwinlouie

taking with sillygwailo

baldwinlouie’s picture

StatusFileSize
new1.09 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

attaching patch

baldwinlouie’s picture

Status:Active» Needs review

changing status

Status:Needs review» Needs work

The last submitted patch, drupal-camelcase-replace-2003460-7451340.patch, failed testing.

heddn’s picture

Status:Needs work» Needs review
aspilicious’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -300,7 +300,7 @@ function operator_options() { return array(); }
+  function operatorValidate($form, &$form_state) { }

I think this should be "protected function operatorValidate()"

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new1.11 KB
FAILED: [[SimpleTest]]: [MySQL] 56,043 pass(es), 2 fail(s), and 1 exception(s).
[ View ]

Added "protected"

Status:Needs review» Needs work

The last submitted patch, views-core-operator_validate-2003460-7.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new1.11 KB
PASSED: [[SimpleTest]]: [MySQL] 57,174 pass(es).
[ View ]

re-roll

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 98c23ed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.