Files: 
CommentFileSizeAuthor
#10 drupal-viewsRename-operator_form-2003438-10.patch.patch5.78 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 57,921 pass(es). View
#8 rename_operator_form-2003438-8.patch4.43 KBtrevjs
PASSED: [[SimpleTest]]: [MySQL] 56,862 pass(es). View
#6 rename_operator_form-2003438-6.patch4.71 KBtrevjs
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#1 8.x-dev-rename_operator_form.patch640 bytestrevjs
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

trevjs’s picture

FileSize
640 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
trevjs’s picture

Status: Active » Needs review
trevjs’s picture

Assigned: trevjs » Unassigned

Status: Needs review » Needs work

The last submitted patch, 8.x-dev-rename_operator_form.patch, failed testing.

trevjs’s picture

Assigned: Unassigned » trevjs
trevjs’s picture

Status: Needs work » Needs review
FileSize
4.71 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Forgot to change callers. Also specified public calling method. In some cases it is called by show_operator_form, and so it may be that this is intended to be a private method. Let me know and I'll change it.

Status: Needs review » Needs work

The last submitted patch, rename_operator_form-2003438-6.patch, failed testing.

trevjs’s picture

Status: Needs work » Needs review
FileSize
4.43 KB
PASSED: [[SimpleTest]]: [MySQL] 56,862 pass(es). View

Re-roll

oenie’s picture

Status: Needs review » Needs work

Hate to throw this back again, but it seems you have missed a spot:

core/modules/search/lib/Drupal/search/Plugin/views/filter/Search.php, line 51:
function operator_form(&$form, &$form_state) {

Be sure to add the access modifier in front of the function as well.
Actually, since the only call to the operatorForm method seem to be on a $this instance, it could actually be protected instead of public.

heddn’s picture

Status: Needs work » Needs review
FileSize
5.78 KB
PASSED: [[SimpleTest]]: [MySQL] 57,921 pass(es). View

It also needed a re-roll. Here goes.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 85ad766 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

link to meta issue