Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

We need to update the views functions with names that match function naming convention.

I'm starting this off assigned to myself.

Files: 
CommentFileSizeAuthor
#11 drupal-viewsRename-get_where_args-2003410-11.patch659 bytespcambra
PASSED: [[SimpleTest]]: [MySQL] 57,575 pass(es).
[ View ]
#7 drupal-viewsRename-get_where_args-2003410-7.patch1.06 KBheddn
FAILED: [[SimpleTest]]: [MySQL] 57,291 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#5 core-rename-get_where_args-function-2003410-5.patch652 bytesricky.middaugh
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#1 core-rename-get_where_args-function-2003410-1.patch652 bytesricky.middaugh
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core-rename-get_where_args-function-2003410-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

ricky.middaugh’s picture

Status:Active» Needs review
StatusFileSize
new652 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core-rename-get_where_args-function-2003410-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Issue ready for review. The function name has been updated.

Status:Needs review» Needs work

The last submitted patch, core-rename-get_where_args-function-2003410-1.patch, failed testing.

ricky.middaugh’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, core-rename-get_where_args-function-2003410-1.patch, failed testing.

ricky.middaugh’s picture

Status:Needs work» Needs review
StatusFileSize
new652 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Updating with new patch.

Status:Needs review» Needs work

The last submitted patch, core-rename-get_where_args-function-2003410-5.patch, failed testing.

heddn’s picture

StatusFileSize
new1.06 KB
FAILED: [[SimpleTest]]: [MySQL] 57,291 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

There's no calls to get_where_args() so I'm guess that it needs to be public. Otherwise how could contrib module use it? Or maybe it isn't used any more, but that's cruft for another issue. Let's see if the testbot is happy today.

aspilicious’s picture

Status:Needs work» Needs review
SpartyDan’s picture

Assigned:ricky.middaugh» Unassigned

Tested patch to make sure it still applies. Queued patch for testing.

Status:Needs review» Needs work

The last submitted patch, drupal-viewsRename-get_where_args-2003410-7.patch, failed testing.

pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new659 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,575 pass(es).
[ View ]

Rerroll, it should pass?

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 9791575 and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

Adding parent issue