Files: 
CommentFileSizeAuthor
#9 rename_views_method-2003368-8.patch5.39 KBmarlatt
PASSED: [[SimpleTest]]: [MySQL] 56,042 pass(es). View
#9 interdiff.txt3.14 KBmarlatt
#8 rename_views_method-2003368-8.patch5.39 KBmarlatt
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
#8 interdiff.txt3.14 KBmarlatt
#6 views-core-rename-pre_execute-2003368-6.patch8.53 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-core-rename-pre_execute-2003368-6.patch. Unable to apply patch. See the log in the details link for more information. View
#5 views-core-rename-pre_execute-2003368-5.patch5.69 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View
#2 Rename_Views_method-2003368-2.patch8.52 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] 55,726 pass(es), 1 fail(s), and 0 exception(s). View

Comments

NonProfit’s picture

Assigned:Unassigned» NonProfit
NonProfit’s picture

Assigned:NonProfit» Unassigned
Status:Active» Needs review
FileSize
8.52 KB
FAILED: [[SimpleTest]]: [MySQL] 55,726 pass(es), 1 fail(s), and 0 exception(s). View

Patch created.

Status:Needs review» Needs work

The last submitted patch, Rename_Views_method-2003368-2.patch, failed testing.

heddn’s picture

Tests failing. Please investigate and re-roll a patch.

SpartyDan’s picture

Status:Needs work» Needs review
FileSize
5.69 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed. View

re-rolled

SpartyDan’s picture

FileSize
8.53 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-core-rename-pre_execute-2003368-6.patch. Unable to apply patch. See the log in the details link for more information. View

Previous patch was not complete.

Status:Needs review» Needs work

The last submitted patch, views-core-rename-pre_execute-2003368-6.patch, failed testing.

marlatt’s picture

Status:Needs work» Needs review
FileSize
3.14 KB
5.39 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.php
@@ -1166,7 +1166,7 @@ public function execute($display_id = NULL) {
     // Let modules modify the view just prior to executing it.
     $module_handler = \Drupal::moduleHandler();
-    $module_handler->invokeAll('views_pre_execute', array($this));
+    $module_handler->invokeAll('views_preExecute', array($this));
 

It looks as though changes were made to another function reference outside the scope of the intended change?

Reversed changes to views_pre_execute references and similiar and re-rolled patch.

marlatt’s picture

FileSize
3.14 KB
5.39 KB
PASSED: [[SimpleTest]]: [MySQL] 56,042 pass(es). View

I apologize, the above interdiff was incorrect, here is the patch and interdiff corrected.

lokapujya’s picture

Status:Needs review» Reviewed & tested by the community

Patch in #8 looks good.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename_views_method-2003368-8.patch, failed testing.

marlatt’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#9: rename_views_method-2003368-8.patch queued for re-testing.

lokapujya’s picture

Status:Needs review» Reviewed & tested by the community

GTG, the re-test passed.

somepal’s picture

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 022531a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.