Files: 
CommentFileSizeAuthor
#9 views.module-summary_name_field-2002982-8.patch2.2 KBdanylevskyi
PASSED: [[SimpleTest]]: [MySQL] 55,973 pass(es). View
#5 views-core-summary_name_field-2002982-05.patch2.2 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 56,075 pass(es). View
#2 views-Rename_method_summary_name_field_to_summaryNameField-2002982-1.patch2.2 KBchr.fritsch
PASSED: [[SimpleTest]]: [MySQL] 55,738 pass(es). View

Comments

chr.fritsch’s picture

Assigned: Unassigned » chr.fritsch
chr.fritsch’s picture

Status: Active » Needs review
FileSize
2.2 KB
PASSED: [[SimpleTest]]: [MySQL] 55,738 pass(es). View
chr.fritsch’s picture

Assigned: chr.fritsch » Unassigned
munizjor’s picture

Status: Needs review » Reviewed & tested by the community

Ran successful test creating a new view.

SpartyDan’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
2.2 KB
PASSED: [[SimpleTest]]: [MySQL] 56,075 pass(es). View

Add access modifier "public", reroll, retest.

@jfm2k1 - Please refer to https://drupal.org/node/1856630#comment-7450696 when reviewing patches related to the drupal.org/node/1856630 Meta issue.

aspilicious’s picture

Status: Needs review » Needs work

This function is only used internally in argument plugins. Probably should be protected in stead of public.

danylevskyi’s picture

Assigned: Unassigned » danylevskyi
danylevskyi’s picture

Assigned: danylevskyi » Unassigned
Status: Needs work » Needs review
danylevskyi’s picture

FileSize
2.2 KB
PASSED: [[SimpleTest]]: [MySQL] 55,973 pass(es). View
podarok’s picture

Issue tags: +CodeSprintUA

tagging

somepal’s picture

reviewed #9 views.module-summary_name_field-2002982-8.patch
gtg

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect.

webchick’s picture

Title: Rename Views method summary_name_field() to summaryNameField() » Change notice: Rename Views method summary_name_field() to summaryNameField()
Project: Drupal core » Views
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

Title: Change notice: Rename Views method summary_name_field() to summaryNameField() » Rename Views method summary_name_field() to summaryNameField()
Project: Views » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Automatically closed -- issue fixed for 2 weeks with no activity.