Files: 
CommentFileSizeAuthor
#9 core-rename_get_field_value_TO_getFieldValue-2002914-9.patch1.15 KBcrowdcg
PASSED: [[SimpleTest]]: [MySQL] 57,665 pass(es). View
#2 VDC-Rename_get_field_value-2002914-2.patch1.14 KBcrowdcg
FAILED: [[SimpleTest]]: [MySQL] 55,791 pass(es), 1 fail(s), and 0 exception(s). View

Comments

crowdcg’s picture

Assigned: Unassigned » crowdcg
Issue tags: +portland2013

Working on this as part of the Portland2013 getting involved with core sprint.

crowdcg’s picture

Status: Active » Needs review
FileSize
1.14 KB
FAILED: [[SimpleTest]]: [MySQL] 55,791 pass(es), 1 fail(s), and 0 exception(s). View

Replaced 2 instances of get_field_value with getFieldValue.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC, -portland2013

The last submitted patch, VDC-Rename_get_field_value-2002914-2.patch, failed testing.

connorwk’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, VDC-Rename_get_field_value-2002914-2.patch, failed testing.

oenie’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC, +portland2013
oenie’s picture

Status: Needs review » Needs work

Patch send for retest, error was due to commit that has since been reverted.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -662,7 +662,7 @@ public function get_field($index, $field) {
+  function getFieldValue($index, $field) {

Add protected access modifier in front of the function to adher to the new OOP standards.

crowdcg’s picture

Working on adding the access modifier.

crowdcg’s picture

Assigned: crowdcg » Unassigned
Status: Needs work » Needs review
FileSize
1.15 KB
PASSED: [[SimpleTest]]: [MySQL] 57,665 pass(es). View

Added protected access. Thanks oenie!

oenie’s picture

Again, patch looks good to me now ! If the patch passed testbot, it's RTBC for me !

oenie’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4da6c73 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

hansfn’s picture

Issue summary: View changes
Status: Closed (fixed) » Active

Add protected access modifier in front of the function to adher to the new OOP standards.

Why exactly? The function getField (which returns the rendered fields) is public. In a module I maintain (Views Send) I need access to both the rendered and raw fields.

PS! I can open a new issue if that is preferred.

alexpott’s picture

Status: Active » Fixed

@hansfn - yep a new issue would be great

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.