Files: 
CommentFileSizeAuthor
#5 drupal-camelcase-replace-2002458.5.patch1004 bytesbaldwinlouie
PASSED: [[SimpleTest]]: [MySQL] 55,701 pass(es).
[ View ]
#2 drupal-camelcase-replace-2002458-7450896.patch997 bytesbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

baldwinlouie’s picture

Assigned:Unassigned» baldwinlouie

taking by baldwinlouie and sillygwailo

baldwinlouie’s picture

StatusFileSize
new997 bytes
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

attaching patch

baldwinlouie’s picture

Status:Active» Needs review

setting to needs review

oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -681,7 +681,7 @@ public function validateFail() {
+  function defaultIgnore() {

Add public access modifier in front of the function to adher to the new OOP standards.

baldwinlouie’s picture

Status:Needs work» Needs review
StatusFileSize
new1004 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,701 pass(es).
[ View ]

re-rolling with access modifier

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed f122f25 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.