Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 views_rename_function-2002456-4.patch1.06 KBericthelast
#2 views_rename_function_2002456-2.patch1.06 KBericthelast

Comments

ericthelast’s picture

ericthelast commented
Assigned: Unassigned » ericthelast

Working on this now.

ericthelast’s picture

ericthelast commented
Status: Active » Needs review
StatusFileSize
new views_rename_function_2002456-2.patch1.06 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -714,7 +714,7 @@ function default_access_denied() {
-  function default_empty() {
+  function defaultEmpty() {
     // We return with no query; this will force the empty text.
     $this->view->built = TRUE;
     $this->view->executed = TRUE;

Add public access modifier in front of the function to adher to the new OOP standards.

ericthelast’s picture

ericthelast commented
Status: Needs work » Needs review
StatusFileSize
new views_rename_function-2002456-4.patch1.06 KB

Adds public access modifier.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

ericthelast’s picture

ericthelast commented

Awesome! Just out of curiosity, is there anything else I need to do now that my patch is good to go?

oenie’s picture

oenie commented

@ericthelast: nope, just wait till it gets committed by one of the core maintainers.
patience is a virtue ! :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6778f6c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.