Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 2002444-rename-default-argument-form-3.patch2.22 KBfmizzell
#2 2002444-rename-default-argument-form.patch2.21 KBfmizzell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Assigned: Unassigned » fmizzell
fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Active » Needs review
FileSize
2002444-rename-default-argument-form.patch2.21 KB
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -497,7 +497,7 @@ function default_actions($which = NULL) {
+  function defaultArgumentForm(&$form, &$form_state) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Date.phpundefined
@@ -47,8 +47,8 @@ class Date extends Formula {
+  function defaultArgumentForm(&$form, &$form_state) {

Add public access modifier in front of the functions to adher to the new OOP standards.

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Needs work » Needs review
FileSize
2002444-rename-default-argument-form-3.patch2.22 KB

adding public to modified methods

Status: Needs review » Needs work

The last submitted patch, 2002444-rename-default-argument-form-3.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

Failing tests. Please test and re-roll.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs work » Needs review

#4: 2002444-rename-default-argument-form-3.patch queued for re-testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 7ff4449 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.