Files: 
CommentFileSizeAuthor
#4 2002444-rename-default-argument-form-3.patch2.22 KBfmizzell
PASSED: [[SimpleTest]]: [MySQL] 57,115 pass(es). View
#2 2002444-rename-default-argument-form.patch2.21 KBfmizzell
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

fmizzell’s picture

Assigned: Unassigned » fmizzell
fmizzell’s picture

Status: Active » Needs review
FileSize
2.21 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -497,7 +497,7 @@ function default_actions($which = NULL) {
+  function defaultArgumentForm(&$form, &$form_state) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Date.phpundefined
@@ -47,8 +47,8 @@ class Date extends Formula {
+  function defaultArgumentForm(&$form, &$form_state) {

Add public access modifier in front of the functions to adher to the new OOP standards.

fmizzell’s picture

Status: Needs work » Needs review
FileSize
2.22 KB
PASSED: [[SimpleTest]]: [MySQL] 57,115 pass(es). View

adding public to modified methods

Status: Needs review » Needs work

The last submitted patch, 2002444-rename-default-argument-form-3.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

oenie’s picture

Status: Needs work » Needs review
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7ff4449 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.