Files: 
CommentFileSizeAuthor
#18 2002442-18.patch6.75 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 55,291 pass(es). View
#15 2002442-rename-default_actions.patch6.75 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,630 pass(es). View
#13 2002442-rename-default_actions.patch6.72 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 57,632 pass(es). View
#9 2002442-9.patch6.72 KBjibran
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002442-9.patch. Unable to apply patch. See the log in the details link for more information. View
#4 drupal-camelcase-replace-2002442.4.patch6.71 KBbaldwinlouie
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es). View
#2 drupal-camelcase-replace-2002442.7450586.patch6.71 KBbaldwinlouie
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh. View

Comments

baldwinlouie’s picture

Assigned: Unassigned » baldwinlouie

taking by baldwinlouie and sillygwailo

baldwinlouie’s picture

Status: Active » Needs review
FileSize
6.71 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed during invocation of run-tests.sh. View

adding patch

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/argument/UserUid.phpundefined
@@ -37,17 +37,17 @@ function title() {
-  function default_actions($which = NULL) {

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTidDepth.phpundefined
@@ -78,16 +78,16 @@ function set_breadcrumb(&$breadcrumb) {
+  function defaultActions($which = NULL) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -440,7 +440,7 @@ public function submitOptionsForm(&$form, &$form_state) {
+  function defaultActions($which = NULL) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Null.phpundefined
@@ -42,17 +42,17 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function defaultActions($which = NULL) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

baldwinlouie’s picture

Status: Needs work » Needs review
FileSize
6.71 KB
PASSED: [[SimpleTest]]: [MySQL] 55,885 pass(es). View

rerolled

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-camelcase-replace-2002442.4.patch, failed testing.

baldwinlouie’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl http://drupal.org/files/drupal-camelcase-replace-2002442.4.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6874  100  6874    0     0  13168      0 --:--:-- --:--:-- --:--:-- 19809
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:734
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
6.72 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002442-9.patch. Unable to apply patch. See the log in the details link for more information. View

Reroll
Conflict

++<<<<<<< HEAD
 +  function hasDefaultArgument() {
 +    $info = $this->default_actions($this->options['default_action']);
++=======
+   function has_default_argument() {
+     $info = $this->defaultActions($this->options['default_action']);
++>>>>>>> 4

Resolved

 -  function has_default_argument() {
 +  function hasDefaultArgument() {
-     $info = $this->default_actions($this->options['default_action']);
+     $info = $this->defaultActions($this->options['default_action']);

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002442-9.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review

#9: 2002442-9.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 2002442-9.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
6.72 KB
PASSED: [[SimpleTest]]: [MySQL] 57,632 pass(es). View

Re-rolled.

aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/argument/UserUid.phpundefined
@@ -37,17 +37,17 @@ function title() {
+  public function defaultActions($which = NULL) {

Should be protected

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTidDepth.phpundefined
@@ -78,16 +78,16 @@ function set_breadcrumb(&$breadcrumb) {
+  function defaultActions($which = NULL) {

protected

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -440,7 +440,7 @@ public function submitOptionsForm(&$form, &$form_state) {
+  function defaultActions($which = NULL) {

protected

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/Null.phpundefined
@@ -42,17 +42,17 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function defaultActions($which = NULL) {

protected

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
6.75 KB
PASSED: [[SimpleTest]]: [MySQL] 55,630 pass(es). View

Re-rolled with protected.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Sorry, doesn't apply. :(

jibran’s picture

Status: Needs work » Needs review
FileSize
6.75 KB
PASSED: [[SimpleTest]]: [MySQL] 55,291 pass(es). View

reroll

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 821dc67 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.