Files: 
CommentFileSizeAuthor
#12 views-core-rename-click_sortable-2002426-12.patch5.17 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,355 pass(es). View
#9 drupal-rename-function-click-sortable-public-2002426-9.patch5.23 KBrootwork
None View
#9 interdiff.txt3.66 KBrootwork
#7 drupal-rename-funtion-click-sortable-2002426-7.patch4.83 KBrootwork
None View
#7 interdiff.txt2.18 KBrootwork
#1 rename-funtion-click-sortable-2002426.patch4.72 KBhugo.lallo
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

hugo.lallo’s picture

Status: Active » Needs review
FileSize
4.72 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View
hugo.lallo’s picture

no_angel’s picture

Assigned: Unassigned » no_angel

working on the patch testing at sprint today

no_angel’s picture

Assigned: no_angel » Unassigned
Status: Needs review » Needs work

I tested the patch and found the old name in these files.

in core/modules/translation_entity/lib/Drupal/translation_entity/Plugin/views/field/TranslationLink.php on line 81
in core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php on lines 527, 535 and 540

thanks to @hosef for his guidance on this testing and review.

oenie’s picture

+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.phpundefined
@@ -223,7 +223,7 @@ function add_field_table($use_groupby) {
+  function clickSortable() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -181,7 +181,7 @@ function click_sort($order) {
+  function clickSortable() {

Add public access modifier in front of the functions to adher to the new OOP standards.

rootwork’s picture

Assigned: Unassigned » rootwork

Working on this.

rootwork’s picture

Renamed the other references to the functions from #4 and added the public modifier in the two places specified in #5.

rootwork’s picture

Status: Needs work » Needs review
rootwork’s picture

Sorry, ignore the last patch, somehow I still missed a couple of places.

This is a revised patch and an interdiff from #1 (not my messed up patch in #7).

dawehner’s picture

This looks nearly perfect.

+++ b/core/modules/translation_entity/lib/Drupal/translation_entity/Plugin/views/field/TranslationLink.phpundefined
@@ -78,9 +78,9 @@ public function query() {
+   * Overrides \Drupal\views\Plugin\views\Plugin\field\FieldPluginBase::clickSortable().

Let's use {@inheritdoc} here.

heddn’s picture

Status: Needs review » Needs work
SpartyDan’s picture

Assigned: rootwork » Unassigned
Status: Needs work » Needs review
FileSize
5.17 KB
PASSED: [[SimpleTest]]: [MySQL] 57,355 pass(es). View

made change suggested in #10

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Thnx!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed eb2b412 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.