Rename Views method click_sort() to clickSort() [#2002424]

Comment	File	Size	Author
#7	rename-views-method-click-sort-2002424-7.patch	1.85 KB	web.dev.cas

#6	rename-views-method-click-sort-2002424-6.patch	1.85 KB	web.dev.cas

#4	2002424-rename-views-method-part2.patch	1.84 KB	web.dev.cas

#2	2002424-rename-views-method.patch	1.24 KB	web.dev.cas

Comment #1

web.dev.cas CreditAttribution: web.dev.cas commented 24 May 2013 at 17:50

Assigned:

Unassigned

» web.dev.cas

Working on this as part of core code sprint.

Log in or register to post comments

Comment #2

web.dev.cas CreditAttribution: web.dev.cas commented 24 May 2013 at 18:11

File	Size
2002424-rename-views-method.patch	1.24 KB

Replaced two instances of click_sort() with clickSort().

Log in or register to post comments

Comment #3

web.dev.cas CreditAttribution: web.dev.cas commented 24 May 2013 at 18:12

Status:

Active

» Needs review

Forgot to set status to needs review.

Log in or register to post comments

Comment #4

web.dev.cas CreditAttribution: web.dev.cas commented 24 May 2013 at 18:31

File	Size
2002424-rename-views-method-part2.patch	1.84 KB

I missed an instance of click_sort(). Attaching new complete patch.

Log in or register to post comments

Comment #5

oenie CreditAttribution: oenie commented 24 May 2013 at 22:06

Status:

Needs review

» Needs work

+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.phpundefined
@@ -240,7 +240,7 @@ function click_sortable() {
+  function clickSort($order) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -165,7 +165,7 @@ function add_additional_fields($fields = NULL) {
+  function clickSort($order) {

Add public access modifier in front of the functions to adher to the new OOP standards.

Log in or register to post comments

Comment #6

web.dev.cas CreditAttribution: web.dev.cas commented 24 May 2013 at 23:41

Status:

Needs work

» Needs review

File	Size
rename-views-method-click-sort-2002424-6.patch	1.85 KB

Added public access modifier to clickSort functions. Thanks, oenie!

Log in or register to post comments

Comment #7

web.dev.cas CreditAttribution: web.dev.cas commented 29 May 2013 at 13:16

File	Size
rename-views-method-click-sort-2002424-7.patch	1.85 KB

The status of the last patch was stuck in "Test request sent" comment display, but on inspecting details, I saw that it in fact failed system test. Resubmitting new version of patch based upon latest repo pull.