Files: 
CommentFileSizeAuthor
#4 rename-views-method-cache-flush-2002398-4.patch1.41 KBweb.dev.cas
PASSED: [[SimpleTest]]: [MySQL] 56,048 pass(es).
[ View ]
#2 2002398-rename-views-method-cache-flush.patch1.4 KBweb.dev.cas
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

web.dev.cas’s picture

Assigned:Unassigned» web.dev.cas

Working on as part of core code sprint.

web.dev.cas’s picture

Status:Active» Needs review
StatusFileSize
new1.4 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Replace two instances of cache_flush() with cacheFlush().

oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -179,7 +179,7 @@ function cache_get($type) {
+  function cacheFlush() {

Add public access modifier in front of the function to adher to the new OOP standards.

web.dev.cas’s picture

Status:Needs work» Needs review
StatusFileSize
new1.41 KB
PASSED: [[SimpleTest]]: [MySQL] 56,048 pass(es).
[ View ]

Added public access modifier to cacheFlush function. Thanks, oenie!

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine by me now.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.